From a90daf9473aa52526ca649f9c6d8445fc539c296 Mon Sep 17 00:00:00 2001
From: Octave Perrin <operrin@lrtechnologies.fr>
Date: Wed, 13 Nov 2024 15:37:58 +0100
Subject: [PATCH] more
---
include/aidge/graph/GraphView.hpp | 10 +++++-----
src/graph/GraphView.cpp | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/aidge/graph/GraphView.hpp b/include/aidge/graph/GraphView.hpp
index 371d1d72e..cae3beaf4 100644
--- a/include/aidge/graph/GraphView.hpp
+++ b/include/aidge/graph/GraphView.hpp
@@ -204,9 +204,9 @@ public:
*/
void setOrderedOutputs(const std::vector<std::pair<NodePtr, IOIndex_t>>& outputs);
- /** @todo i don't understand the description
- * @brief Get a topological node order for an acyclic walk of the graph
- * Graph cycles are broken on operator back edges such that resolution on
+ /**
+ * @brief Get a topological node order for an acyclic walk of the graph.
+ * @details Graph cycles are broken on operator back edges such that resolution on
* single level lattice can be done in a single pass as it is
* the case generally for static resolution of Tensor shapes/datatypes.
* When reversed is true, gets a topological order on the reversed graph
@@ -239,12 +239,12 @@ public:
* @brief List outside data input connections of the GraphView.
* Data inputs exclude inputs expecting parameters (weights or bias).
* The vector size is guaranteed to match the number of outside data inputs of the GraphView. If there is
- * no external connection to a given input, a pair of nullptr and gk_IODefaultIndex is returned. @todo check it, for me it seem every unconnected input will add some nullptr to the list
+ * no external connection to a given input, a pair of nullptr and gk_IODefaultIndex is returned.
* @return std::vector<std::pair<NodePtr, IOIndex_t>>
*/
std::vector<std::pair<NodePtr, IOIndex_t>> dataInputs() const;
- /** @todo check it
+ /**
* @brief List all dataInput connections (within and outside) of the specified GraphView node named "name".
* Data inputs exclude inputs expecting parameters (weights or bias).
* @param name Name of the Node.
diff --git a/src/graph/GraphView.cpp b/src/graph/GraphView.cpp
index 626270ce4..a6d30931b 100644
--- a/src/graph/GraphView.cpp
+++ b/src/graph/GraphView.cpp
@@ -375,7 +375,7 @@ Aidge::IOIndex_t Aidge::GraphView::getNbFreeDataInputs() const {
std::vector<std::pair<std::shared_ptr<Aidge::Node>, Aidge::IOIndex_t>>
Aidge::GraphView::dataInputs() const {
- std::vector<std::pair<std::shared_ptr<Node>, IOIndex_t>> res;
+ std::vector<std::pair<std::shared_ptr<Node>, IOIndex_t>> res; //todo three letters or less variable names should be illegal
for (const std::shared_ptr<Node>& inputNode : inputNodes()) {
const std::vector<std::pair<std::shared_ptr<Node>, IOIndex_t>> inputNodeinputs =
--
GitLab