Skip to content
Snippets Groups Projects

Fix compilation on MacOS

Merged Maxence Naud requested to merge fix_49_compilation-macos into dev
All threads resolved!

Context

Closes #49 (closed)

Major changes

  • fix: use aidge 'approxEq' function instead of manual comparison and change CHECKs for REQUIREs in interpolation test
  • fix: error related to std::fma calls with different input types in GlobalAvgPooling and ReduceMean kernels. Also simplify GlobalAvgPooling logic
Edited by Maxence Naud

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Maxence Naud changed title from fix: use aidge 'approxEq' function instead of manual comparison and change... to Fix compilation on MacOS

    changed title from fix: use aidge 'approxEq' function instead of manual comparison and change... to Fix compilation on MacOS

  • Maxence Naud added 13 commits

    added 13 commits

    • 8ed63d19...afd3dee9 - 11 commits from branch dev
    • 54455ecf - fix: error related to 'fma' call with different input types. Also simplify GlobalAvgPooling logic
    • 9fea6486 - fix: use aidge 'approxEq' function instead of manual comparison and change...

    Compare with previous version

  • Maxence Naud added 1 commit

    added 1 commit

    • cd824d73 - fix: move back 'castFromFloat' function in GloabalAvgPoolingImpl_kernel as...

    Compare with previous version

  • Maxence Naud resolved all threads

    resolved all threads

  • Author Maintainer

    Merge since every thread is resolved.

  • closed

  • reopened

  • Maxence Naud enabled an automatic merge when all merge checks for cd824d73 pass

    enabled an automatic merge when all merge checks for cd824d73 pass

  • merged

  • Please register or sign in to reply
    Loading