Merge branch '25-acts-are-not-started-with-autogenerated-engine' into 'main'

 Allow Acts and Events to trigger at different times

Closes #25

See merge request eclipse/openpass/openscenario1_engine!116

engine/demo/example/scenario.xosc

@@ -120,7 +120,7 @@
               </Action>
               <StartTrigger>
                 <ConditionGroup>
-                  <Condition name="NotAtStart" delay="0" conditionEdge="rising">
+                  <Condition name="NotAtStart" delay="0" conditionEdge="none">
                     <ByValueCondition>
                       <SimulationTimeCondition value="0" rule="greaterThan" />
                     </ByValueCondition>
@@ -148,9 +148,9 @@
         </ManeuverGroup>
         <StartTrigger>
           <ConditionGroup>
-            <Condition name="EndTime" delay="0" conditionEdge="rising">
+            <Condition name="FromStart" delay="0" conditionEdge="rising">
               <ByValueCondition>
-                <SimulationTimeCondition value="5.0" rule="greaterThan"/>
+                <SimulationTimeCondition value="0.0" rule="greaterOrEqual" />
               </ByValueCondition>
             </Condition>
           </ConditionGroup>

engine/src/Node/TriggerableCompositeNode.h

@@ -209,14 +209,14 @@ private:
   ///@brief tick as if no stop trigger would decorate the start trigger
   void tickWithStartTrigger()
   {
-    if (start_trigger_node_)
+    if (start_trigger_node_ && start_trigger_status != NodeStatus::kSuccess)
     {
-      const auto status = start_trigger_node_->executeTick();
-      if (status == NodeStatus::kRunning)
+      start_trigger_status = start_trigger_node_->executeTick();
+      if (start_trigger_status == NodeStatus::kRunning)
       {
         return;
       }
-      if (status == NodeStatus::kFailure)
+      if (start_trigger_status == NodeStatus::kFailure)
       {
         throw std::runtime_error("StartTrigger reported failure");
       }
@@ -249,6 +249,7 @@ private:
     return NodeStatus::kRunning;
   }
 
+  NodeStatus start_trigger_status{NodeStatus::kIdle};
   TransientNode::Ptr stop_trigger_node_{nullptr};
   TransientNode::Ptr start_trigger_node_{nullptr};
   TransientNode::Ptr m_child_node{nullptr};