Skip to content

Use POSIX string compare

mk/toolchain_check.sh generates lots of warnings on Ubuntu, but not CentOS. According to this post on stackoverflow, == is a bash-ism, and it is recommended to use the POSIX =. With this change the warnings are no longer emitted under either Ubuntu20.04 or CentOS 7.

Just for completeness, the warnings received before this pull-request:

mk/toolchain_check.sh: 36: [: NO: unexpected operator
mk/toolchain_check.sh: 41: [: NO: unexpected operator
mk/toolchain_check.sh: 46: [: NO: unexpected operator
mk/toolchain_check.sh: 51: [: NO: unexpected operator
mk/toolchain_check.sh: 56: [: NO: unexpected operator
mk/toolchain_check.sh: 61: [: YES: unexpected operator

Merge request reports

Loading