Modernize devcontainer desc

* Put vscode specifics in customizations/vscode
* Add temp workaround for docker v23
* Fix tests by making C++17 public requirement of agnostic_behavior_tree

Signed-off-by: Martin Stump <martin.stump@mercedes-benz.com>

.cmake-format

-additional_commands:
-  configure_package_config_file:
-    flags:
-      - NO_SET_AND_CHECK_MACRO
-      - NO_CHECK_REQUIRED_COMPONENTS_MACRO
-    kwargs:
-      INSTALL_DESTINATION: "*"
-      PATH_VARS: "*"
-      INSTALL_PREFIX: "*"
-  find_dependency:
-    flags:
-      - CONFIG
-      - QUIET
-      - REQUIRED
-    kwargs:
-      COMPONENTS: "*"
-  gtest_discover_tests:
-    flags:
-      - NO_PRETTY_TYPES
-      - NO_PRETTY_VALUES
-    kwargs:
-      EXTRA_ARGS: "*"
-      WORKING_DIRECTORY: "*"
-      TEST_PREFIX: "*"
-      TEST_SUFFIX: "*"
-      PROPERTIES: "*"
-      TEST_LIST: "*"
-      DISCOVERY_TIMEOUT: "*"
-command_case: canonical
-dangle_parens: true
-first_comment_is_literal: true
-keyword_case: upper
-line_width: 120
-tab_size: 2
+parse:
+  additional_commands:
+    configure_package_config_file:
+      flags:
+        - NO_SET_AND_CHECK_MACRO
+        - NO_CHECK_REQUIRED_COMPONENTS_MACRO
+      kwargs:
+        INSTALL_DESTINATION: "*"
+        PATH_VARS: "*"
+        INSTALL_PREFIX: "*"
+    find_dependency:
+      flags:
+        - CONFIG
+        - QUIET
+        - REQUIRED
+      kwargs:
+        COMPONENTS: "*"
+    gtest_discover_tests:
+      flags:
+        - NO_PRETTY_TYPES
+        - NO_PRETTY_VALUES
+      kwargs:
+        EXTRA_ARGS: "*"
+        WORKING_DIRECTORY: "*"
+        TEST_PREFIX: "*"
+        TEST_SUFFIX: "*"
+        PROPERTIES: "*"
+        TEST_LIST: "*"
+        DISCOVERY_TIMEOUT: "*"
+format:
+  dangle_parens: true
+  line_width: 120
+  tab_size: 2
+markup:
+  first_comment_is_literal: true

.devcontainer/devcontainer.json

 {
 	"name": "Yase",
 	"build": {
-		"dockerfile": "Dockerfile"
+		"dockerfile": "Dockerfile",
+		"args": {
+			// NOTE temp workaround for docker v23, see https://github.com/microsoft/vscode-remote-release/issues/7958
+			"BUILDKIT_INLINE_CACHE": "0"
+		}
 	},
 	"capAdd": [
 		"SYS_PTRACE"
@@ -9,33 +13,38 @@
 	"securityOpt": [
 		"seccomp=unconfined"
 	],
-	"extensions": [
-		"cheshirekow.cmake-format",
-		"ms-vscode.cmake-tools",
-		"ms-vscode.cpptools",
-		"ms-vscode.live-server",
-		"redhat.vscode-yaml"
-	],
 	"features": {
 		"ghcr.io/balazs23/devcontainers-features/bazel:1": {}
 	},
-	"settings": {
-		"C_Cpp.codeAnalysis.clangTidy.enabled": true,
-		"C_Cpp.default.compileCommands": "${workspaceFolder}/build/compile_commands.json",
-		"C_Cpp.default.configurationProvider": "ms-vscode.cmake-tools",
-		"cmake.exportCompileCommandsFile": true,
-		"cmake.generator": "Ninja",
-		"cmake.installPrefix": "${workspaceFolder}/build/prefix",
-		"editor.formatOnSave": true,
-		"editor.tabSize": 2,
-		"files.associations": {
-			".clang-format": "yaml",
-			".clang-tidy": "yaml",
-			".clangd": "yaml",
-			".cmake-format": "yaml"
-		},
-		"files.insertFinalNewline": true,
-		"files.trimFinalNewlines": true,
-		"files.trimTrailingWhitespace": true
+	"customizations": {
+		"vscode": {
+			"extensions": [
+				"cheshirekow.cmake-format",
+				"ms-vscode.cmake-tools",
+				"ms-vscode.cpptools",
+				"ms-vscode.live-server",
+				"redhat.vscode-yaml"
+			],
+			"settings": {
+				"C_Cpp.codeAnalysis.clangTidy.enabled": true,
+				"C_Cpp.default.compileCommands": "${workspaceFolder}/build/compile_commands.json",
+				"C_Cpp.default.configurationProvider": "ms-vscode.cmake-tools",
+				"cmake.exportCompileCommandsFile": true,
+				"cmake.generator": "Ninja",
+				"cmake.installPrefix": "${workspaceFolder}/build/prefix",
+				"editor.formatOnSave": true,
+				"editor.tabSize": 2,
+				"files.associations": {
+					".clang-format": "yaml",
+					".clang-tidy": "yaml",
+					".clangd": "yaml",
+					".cmake-format": "yaml",
+					"*.cmake.in": "cmake"
+				},
+				"files.insertFinalNewline": true,
+				"files.trimFinalNewlines": true,
+				"files.trimTrailingWhitespace": true
+			}
+		}
 	}
 }

agnostic_behavior_tree/src/CMakeLists.txt

@@ -49,4 +49,4 @@ target_include_directories(
   agnostic_behavior_tree PUBLIC $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include> $<INSTALL_INTERFACE:include>
 )
 
-target_compile_features(agnostic_behavior_tree PRIVATE cxx_std_17)
+target_compile_features(agnostic_behavior_tree PUBLIC cxx_std_17)