Skip to content
Snippets Groups Projects
Commit 550343d8 authored by Octave Perrin's avatar Octave Perrin
Browse files

more questions to ask

parent 30888295
No related branches found
No related tags found
No related merge requests found
......@@ -659,7 +659,7 @@ private:
* inputs/outputs after adding this node.
* @param nodePtr
*/
//@todo 100+ lines =(
//@todo 1see in code comment
void updateInputsOutputsNew(NodePtr newNode);
//@todo 100+ lines =(
......
......@@ -1282,7 +1282,7 @@ void Aidge::GraphView::updateInputsOutputsNew(std::shared_ptr<Node> newNode) {
// Check that it was not already the case (if node UPDATE)
if (iter != mInputNodes.cend()) { // newNode is linked to an actual inputNode to an input connection
// The first old (removed) input becomes the insertion point for newNode GraphView inputs
if (std::distance(newInputsInsertionPoint, iter) <= 0) {
if (std::distance(newInputsInsertionPoint, iter) <= 0) { //todo ask for dis part
newInputsInsertionPoint = mInputNodes.erase(iter);
}
else {
......@@ -1360,7 +1360,7 @@ void Aidge::GraphView::updateInputsOutputsNew(std::shared_ptr<Node> newNode) {
break;
}
}
// todo: from what i understood: for each output if at least one child is in the graph we don't add anything which is weird as an output could send to both in and out the graph
if (noInsideConnection) {
const auto val = std::make_pair(newNode, outputIdx);
// Output may be already be present (see addChild() with a node already in GraphView)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment