| ... | ... | @@ -2,17 +2,17 @@ |
|
|
|
|
|
|
|
Everybody. Only comitters will be allowed to push on the project and launch pipelines but nothing stops you from contribute & review other's code.
|
|
|
|
|
|
|
|
This page is here to guide you in the process of creating a clean merge request or review a merge request.
|
|
|
|
This page is here to guide you in the process of creating a clean merge request or review a merge request.
|
|
|
|
|
|
|
|
[[_TOC_]]
|
|
|
|
|
|
|
|
# How to review a merge request
|
|
|
|
|
|
|
|
#### :new:First contribution ?
|
|
|
|
#### :new: First contribution ?
|
|
|
|
|
|
|
|
If this is the first contribution of a new contributor, redirect him to the contribution rules before reviewing code.
|
|
|
|
|
|
|
|
#### :deciduous_tree:Git flow
|
|
|
|
#### :deciduous_tree: Git flow
|
|
|
|
|
|
|
|
##### MR configuration
|
|
|
|
|
| ... | ... | @@ -48,11 +48,11 @@ If a merge request(A) depends on another merge request(B) (i.e. A must be merged |
|
|
|
|
|
|
|
#### 🧪 Testing
|
|
|
|
|
|
|
|
Every new feature / bug fix must be accompanied by a new test that ensures the stability of the codebase (i.e. that the error won't happen anymore).
|
|
|
|
Every new feature / bug fix must be accompanied by a new test that ensures the stability of the codebase (i.e. that the error won't happen anymore).
|
|
|
|
|
|
|
|
Proofread and verify tests.
|
|
|
|
|
|
|
|
#### :train: CI Pipeline
|
|
|
|
#### :train: CI Pipeline
|
|
|
|
|
|
|
|
> :warning:**If you are a comitter**
|
|
|
|
>
|
| ... | ... | @@ -66,7 +66,7 @@ If the merge request is not a simple an operator addition it must be accompanied |
|
|
|
|
|
|
|
#### :book: Documentation
|
|
|
|
|
|
|
|
Each function must be provided with :
|
|
|
|
Each function must be provided with :
|
|
|
|
|
|
|
|
* doxygen for C++
|
|
|
|
* docstring for python/pybind
|
| ... | ... | @@ -83,7 +83,7 @@ If an equivalent onnx operator is available, the reviewer must understand how it |
|
|
|
>
|
|
|
|
> The real specification is that the operator must be importable & exportable with regard to onnx over all available opsets.
|
|
|
|
|
|
|
|
Required :
|
|
|
|
Required :
|
|
|
|
|
|
|
|
* Python bindings of the operator
|
|
|
|
* Tests on core, backends & onnx repos.
|
| ... | ... | |