Happy shellcheck + fix logical issue with usage()'s exit

github/github-membership.sh

@@ -3,35 +3,39 @@ set -euo pipefail
 IFS=$'\n\t'
 
 list_active_membership () {
+  local ORGS ORG
   ORGS=$(gh api user/memberships/orgs --paginate | jq '.[] | select(.state | contains("active"))' | jq -r ".organization.login")
   echo "Member of the following GitHub organizations:"
-  for ORG in $ORGS
+  for ORG in ${ORGS}
   do
-    echo "  $ORG"
+    echo "  ${ORG}"
   done
 }
 
 list_pending_membership () {
+  local ORGS ORG
   ORGS=$(gh api user/memberships/orgs --paginate | jq '.[] | select(.state | contains("pending"))' | jq -r ".organization.login")
   echo "Invitation to join the following GitHub organizations:"
-  for ORG in $ORGS
+  for ORG in ${ORGS}
   do
-    echo "  $ORG"
+    echo "  ${ORG}"
   done
 }
 
 join_pending_membership () {
+  local ORGS
   ORGS=$(gh api user/memberships/orgs --paginate | jq '.[] | select(.state | contains("pending"))' | jq -r ".organization.login")
-  for ORG in $ORGS
+  for ORG in ${ORGS}
   do
-    echo "Joining org $ORG"
-    gh api user/memberships/orgs/$ORG --method PATCH --silent -f state="active"
+    echo "Joining org ${ORG}"
+    gh api "user/memberships/orgs/${ORG}" --method PATCH --silent -f state="active"
   done
 }
 
-usage() { 
+usage() {
+  local USAGE
   USAGE="
-Usage: $(basename $0) [OPTIONS]
+Usage: $(basename "${0}") [OPTIONS]
 
 Options:
   -a      display active organization memberships
@@ -41,7 +45,6 @@ Options:
 
 "
   echo "$USAGE"
-  exit 1
 }
 
 ACTION=""
@@ -60,6 +63,7 @@ while getopts "apj" opt; do
             ;;
         *)
             usage
+            exit 0
             ;;
     esac
 done
@@ -79,7 +83,7 @@ fi
 case $ACTION in
   "list-active") list_active_membership ;;
   "list-pending") list_pending_membership ;;
-  "join-pending") join_pending_membership ;;  
+  "join-pending") join_pending_membership ;;
    *) exit 1 ;;
 esac