Election Reminder triggers to often / Token is included in the subject

Summary

Currently, I get every hour one email with the same content.

Steps to reproduce

(How one can reproduce the issue - this is very important)

What is the current bug behavior?

What is the expected correct behavior?

(What you should see instead)

Relevant logs and/or screenshots

(Add a link to or paste any relevant logs - please use code blocks (```) to format console output, logs, and code, as it's very hard to read otherwise.)

Priority

• Urgent
• High
• Medium
• Low

Severity

• Blocker
• Major
• Normal
• Low

Impact

(What is the impact of this issue? Is it blocking a release? Are there any time constraints?, for example: "We have a release tomorrow")

assigned to @heurtemattes

added IT-priorityhigh IT-severitymajor service:mailing-list statetodo team:infra labels

added statewip label and removed statetodo label

assigned to @heurtemattes

@ariexinger Thanks for reporting. It should be ok now. Let us know if you receive new reminder emails.

removed statewip label

closed

Looks good! Thank you so much @heurtemattes!

moved from eclipsefdn/helpdesk#4658 (moved)

reopened

assigned to @epoirier and unassigned @heurtemattes

I am re-opneing the issue. While the cron job was disabled, we still need to fix the root of the problem.

This is a regression from our migration to of projects.eclipse.org to Drupal 10.

The cron job for elections reminder should run once a day not every hour.

marked this issue as blocking #273 (closed)

changed title from Bug in Mailing Service to Election Reminder triggers to often / Token is included in the subject

added team:webdev label

added webdev:php label

added priorityhigh label

added severitymajor label

A fix has been merged to production to update the cron job schedule to run once a day. The cron job is enabled again.

We also enabled a mail logging module to monitor closely the emails that are sent out.

I will keep this issue opened until I can confirm that emails are being sent properly.

@epoirier, @cguindon, it looks like, there are still some bugs in...

And I am missing a notification for this election: https://projects.eclipse.org/projects/automotive.sdv-blueprints/elections/election-mario-alberto-ortegon-cabrera-eclipse-sdv

Thanks, I'll have a look at this.

I created a MR which has been merged to production to fix this typo.

https://gitlab.eclipse.org/eclipsefdn/it/websites/drupal/eclipsefdn/-/merge_requests/411

closed

Hi @epoirier, not sure if the "new" behaviour is correct, but it looks like, that we do not receive "Committer Election has started" emails anymore ... Here is an example from tractus-x:

Will we get a notification only, when the committer votes are done? Thx!

(As I do not know, if this is the right place, I will keep this issue closed for now...)

I made an update earlier today to make sure to CC the PMC dev list on election creation.

So now the project's dev list + the PMC dev list should recieve the email that a new election was created for a project.

Is this not the case?

This is the issue I worked on today:

#324 (closed)

Thx for your answer, the election creation was sent to the project's dev list and cc'ed to EMO mailing list... But maybe there is a timing issue, because the election creation was done 09:17am CEST and your MR is about 2hours old right now ...

yeah I think my changes were not yet on production at the time the election got created.

Hi @epoirier, found following behaviour today:

Project Lead election was triggered:

but a committer election was announced:

Does it work as intended or is it a bug? For me it was a bit misleading in the first step ...

Thx!

Best, Andy

It seems like the subject of the email is somewhat hard coded to say "Committer election for ...".

We can update that so that its more dynamic that the type of election (Project Lead or Committer).

I created the following issue to take care of that.

#327 (closed)

Hi @epoirier, sorry, found the next "issue"...

Yesterday, I received a notification for an approved election ... ;-) If I have it right in mind, Harald approved on May 24th.

Could you please have a look on that? Thx!

Please find attached the notification.

Thanks for pointing this out. I'll have a look at that!

From what I can see, this email is only triggered when the election's state changes to Complete. This is something that happens in a cron job when an election is ongoing. If the election is approved, it's being ignored. Looking at the revisions of that election, and it didn't change recently. So for now i'm still not sure how this email was sent.

The lack of email logs is not helping here.

I'll have a look at enabling logging for sent emails it's going to give us a better understanding for situations like this one.

The lack of email logs is not helping here.

You may want to take a look at the mailing-list archives, it can help you understand what was sent out: https://accounts.eclipse.org/mailing-list/automotive-pmc

@cguindon At a quick glance, I can see that the PMC email sent on June 13th is a bit different from usual.

June 13th: Posted 09:39 by emo

From: emo@xxxxxxxxxxxxxxxxxxxxxx

June 12th: Posted 00:05 by Eclipse Foundation

From: Eclipse Foundation emo@xxxxxxxxxxxxxxxxxxxxxx

We can see in each emails that the sender is a bit different.

From what I can see, the production website uses Eclipse Foundation as the name of the sender so that would be the one sent on June 12th.

It's possible that the staging server could've sent the email on June 13th since it's using the maillog module and this module doesn't let you add a name for the sender and the option to send emails while using the module is currently enabled. But i'm not seeing any updates for this election on staging.

I'll prepare a merge request to disable the ability to send emails while using the module on staging.

I created the following MR to take care of these configs.

https://gitlab.eclipse.org/eclipsefdn/it/websites/projects.eclipse.org/-/merge_requests/152

Thank you so much!

Sorry again, but I think I found the next deviations:

1. Yesterday, we approved the Project Lead election of Evelyn, but there was no "election complete" email sent out. Not sure, if this works as intended.

2. On Saturday, a reminder email was sent for committer approval. The email mentioned, that the election will close "tomorrow" (Sunday, June 16th), but the election is open till June 19th. Could you please have a look on that? Thank you so much!

Hi @ariexinger, looking at the code of both Drupal 10 and Drupal 7 implementation (to make sure D10 was implemented correctly) and I can see that when a PMC approves a PL election, an email is sent to emo@eclipse.org only.

@wbeaton both D7 and D10 is configured this way. Should it still be this way or should we send an email to the mailing lists as well just like we do for a CM election?

Thanks.

reopened

I'm looking into alternatives because even with the MR that I created, the maillog and smtp modules don't seem to work well together.

I found the following MR which intergrates with maillog module into the smtp module.

https://www.drupal.org/project/smtp/issues/2920034

I also found the following module that does mail logging but I have to test it.

https://www.drupal.org/project/mail_safety

I also found the following MR that applies to another module called SwiftMailer which we are not using but we could create an MR similar to this one with the SMTP module.

https://git.drupalcode.org/project/maillog/-/merge_requests/4/diffs

After some testing we opted to create our own Mail system plugin which uses the Maillog module for logging and the SMTP module to send emails.

The projects.eclipse.org website currently logs all outgoing emails and we will have a better understanding of what is being sent out from now on.

All other drupal 10 websites are configured to use the same feature but currently doesn't log anything as it's currently not needed.

For now I think we can close this issue and keep an eye on the logs for any behaviour that doesn't look good.

Please reopen this issue if you keep getting emails that doesn't seem right.

Thanks!

closed

reopened

On Saturday, a reminder email was sent for committer approval. The email mentioned, that the election will close "tomorrow" (Sunday, June 16th), but the election is open till June 19th. Could you please have a look on that? Thank you so much!

I'm going to have a look at that tomorrow.

I updated the reminder email text to show the end date rather then saying it's going to end "tomorrow".

Closing this issue but please reopen if there's anything wrong with the reminder emails.

In the meantime, we will keep a close eye on the logs and see if we can catch anything there.

Thanks!

closed

Thank you so much @epoirier!