#76 - Create a Past Events page
Signed-off-by: Eric Poirier eric.poirier@eclipse-foundation.org
Merge request reports
Closed by
(Mar 14, 2025 12:59am UTC)
Activity
Created by: netlify[bot]
Deploy preview for eclipsefdn-openadx ready!
Built with commit 3754658cebd0968c7cfcc65a01b1642df24cdf90
34 <p class="events-list-link text-right"><a class="btn btn-secondary" href="{{- with .Params.link | default .RelPermalink }} {{.}} {{- end }}">Learn more</a></p> 35 </div> 36 </div> 37 {{ end }} 26 {{ range first 5 (sort (where .Site.Pages "Section" "events") "Params.date" "desc") }} 27 {{ if isset .Params "end_date" }} 28 {{ $t := time .Params.end_date }} 29 {{ if $t.After now }} 30 <div class="row news-item"> 31 <div class="col-sm-16"> 32 <p class="margin-bottom-0"><strong>{{ .Title }}</strong></p> 33 <p class="margin-bottom-0">{{ .Params.location }}</p> 34 <p>{{ .Params.event_date }}</p> 35 </div> 36 <div class="col-sm-8"> 37 <p class="events-list-link text-right"><a class="btn btn-secondary" href="{{- with .Params.link | default .RelPermalink }} {{.}} {{- end }}">Learn more</a></p> -
Review: Changes requested
This PR is causing a regression for news on the homepage: https://deploy-preview-87--eclipsefdn-openadx.netlify.app/
This PR is causing a regression for news on the homepage: https://deploy-preview-87--eclipsefdn-openadx.netlify.app/
For the news or Events section?
-
This PR is causing a regression for news on the homepage: https://deploy-preview-87--eclipsefdn-openadx.netlify.app/
For the news or Events section?
All good now! I did not notice at first that you made a change to the homepage to hide past events!
-
Created by: ariexi
@ariexi What is your preference here? Should we close this or would you prefer we create an event archive on this site?
Good question! Will the archive contain all past events including the events from the new events site or only the event from the WG page like
content/events/2020-02-28.md?Did I understand it right, that an archive will come in the future for every WG? If yes, then I will wait and we can close this issue. Thx
-
These are the events that we have in our system right now: https://newsroom.eclipse.org/api/events?parameters[publish_to][]=openadx
We would need someone to submit the missing events via https://newsroom.eclipse.org/node/add/events.
I posted some information about this here: https://github.com/EclipseFdn/events.eclipse.org/issues/15#issuecomment-633633695
-
Created by: ariexi
These are the events that we have in our system right now: https://newsroom.eclipse.org/api/events?parameters[publish_to][]=openadx
Yes, these are the current events.
We would need someone to submit the missing events via https://newsroom.eclipse.org/node/add/events.
If this means, I should create the past events, I will do this, if this will make no problems.
I posted some information about this here: EclipseFdn/events.eclipse.org#15 (comment)
-
Created by: ariexi
@ariexi are the news better now?
@chrisguindon , yes, it is looking great now! Thank you so much! Best, Andy
