feat: use hyphens

This makes the FAQ headings have IDs with hyphens. This is more in line with how Hugo handles the IDs for headings created in Markdown.

This shouldn't break any existing links - I don't believe this shortcode is used anywhere.

I tried to remove the TOC from this shortcode in favour of the table_of_contents shortcode we recently added to the theme. However, shortcode HTML headings are not added to Hugo's built-in TOC data structure. So, we still need to keep this duplicate code.

layouts/shortcodes/faq.html

+{{/*
+  Copyright (c) 2024 Eclipse Foundation, Inc.
+
+  This program and the accompanying materials are made available under the
+  terms of the Eclipse Public License v. 2.0 which is available at
+  http://www.eclipse.org/legal/epl-2.0.
+
+  SPDX-License-Identifier: EPL-2.0
+*/}}
+
 {{ $data := index .Site.Data .Site.Language.Lang }}
 <h2>{{ i18n "faq-list-heading" }}</h2>
 <ul>
   {{ range $data.faq.mainEntity }}
-    <li><a href="#{{ replace .name " " "_" }}">{{ .name | safeHTML }}</a></li>
+    <li><a href="#{{ replace .name " " "-" }}">{{ .name | safeHTML }}</a></li>
   {{ end }}
 </ul>
 <hr>
 {{ range $data.faq.mainEntity }}
-  <h2 class="h4" id="{{ replace .name " " "_" }}">{{ .name | safeHTML }}</h2>
+  <h2 class="h4" id="{{ replace .name " " "-" }}">{{ .name | safeHTML }}</h2>
   {{ .acceptedAnswer.text  | safeHTML }}
   <hr>
 {{ end }}