Remove wildcard flags not present in busybox that crash the MM import
After migrating to stack-build-agent, build began to fail due to --wildcard flag on the tar command. In busybox, which is the shell impl used in the build agent, this flag is not present and causes errors. As we already have cleanup, this won't make the build image any larger but will result in slightly longer and larger intermediate images as it extracts a few extra files.
Merge request reports
Activity
requested review from @fgurr, @mbarbero, @heurtemattes, and @cguindon
added 1 commit
- 3434218b - Update maxmind build to use subshell instead of pushd/popd
added 1 commit
- 9172fef0 - Update maxmind build to use subshell instead of pushd/popd
added 1 commit
- ef1c4e40 - Update CD command to have quotes around variable
added 1 commit
- 6514e6b1 - Update makefile to not rewrite the Maxmind location for prod build
added 1 commit
- 27077a9c - Update maxmind stash to use glob pattern match
I think I've taken this as far as I can...I've added extra logging and added a glob-style match string to the maxmind stash command. When running the build we are still getting errors on the stash command according to the Jeknins MR build:
No files included in stash ‘maxmind’Additional logs are available on pipeline step
| Shell Script - (3.2 sec in self) | mkdir -p /tmp/maxmind && ./bin/maxmind.sh /tmp/maxmind |. I can see that there should be files, but they aren't being detected by my wildcard blob as I would expect.124 124 sh 'make production-build' 125 125 stash includes: 'target/', name: 'target' 126 126 dir('/tmp') { 127 stash includes: 'maxmind/', name: 'maxmind' 127 stash includes: 'maxmind/**/*', name: 'maxmind' 128 128 } 129 129 } - Comment on lines 120 to 129
AFAICT, there is problem with /tmp (for some reasons). Try to do all of that outside of /tmp, e.g.
withCredentials([string(credentialsId: 'maxmind-license-key', variable: 'MAXMIND_LICENSE_KEY')]) { sh 'mkdir -p maxmind && ./bin/maxmind.sh maxmind' } sh 'make production-build' stash includes: 'target/', name: 'target' stash includes: 'maxmind/', name: 'maxmind' stash includes: 'maxmind/**/*', name: 'maxmind'
added 1 commit
- 47581412 - Update maxmind bind location in makefile command used for prod build
mentioned in commit fac166b9