Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • G geoip-rest-api
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Eclipse FoundationEclipse Foundation
  • IT
  • APIs
  • geoip-rest-api
  • Issues
  • #5
Closed
Open
Issue created Jan 07, 2020 by Martin Lowe@malowe🇨🇦Maintainer

Remove SQLNetworkService

As we've moved from using SQL to using CSV data, we should remove unneeded services and DAOs from our code to reduce confusion. The following classes should be removed:

  • org.eclipsefoundation.geoip.client.service.impl.SQLNetworkService
  • org.eclipsefoundation.geoip.client.dao.MariaDBDao

And the following test:

  • org.eclipsefoundation.geoip.client.dao.MockMariaDBDao

We should also delete the following properties in the file src/main/resources/application.properties:

  • quarkus.datasource.driver
  • quarkus.datasource.url
  • quarkus.datasource.username
  • quarkus.datasource.min-size
  • quarkus.datasource.max-size
Assignee
Assign to
Time tracking

Copyright © Eclipse Foundation, Inc. All Rights Reserved.     Privacy Policy | Terms of Use | Copyright Agent