Skip to content
Snippets Groups Projects
Commit 6ac2acbe authored by Zachary Sabourin's avatar Zachary Sabourin
Browse files

Merge branch 'zacharysabourin/master/28' into 'master'

feat: Increase code quality

See merge request !35
parents 8e51b4f3 67b8380a
No related branches found
No related tags found
1 merge request!35feat: Increase code quality
Pipeline #30701 passed
......@@ -27,7 +27,7 @@ import io.quarkus.test.junit.QuarkusTest;
*
*/
@QuarkusTest
public class SubnetResourceTest {
class SubnetResourceTest {
public static final String SUBNETS_ENDPOINT_URL = "/subnets/{subnet}/{locale}";
public static final EndpointTestCase IPV4_SUCCESS = TestCaseHelper.buildSuccessCase(SUBNETS_ENDPOINT_URL,
......@@ -61,13 +61,13 @@ public class SubnetResourceTest {
// bad ipv4 calls
for (String locale : badLocales) {
testCase = TestCaseHelper.buildBadRequestCase(SUBNETS_ENDPOINT_URL, new String[] { "ipv4", locale }, "");
testCase = TestCaseHelper.buildNotFoundCase(SUBNETS_ENDPOINT_URL, new String[] { "ipv4", locale }, "");
RestAssuredTemplates.testGet(testCase);
}
// bad ipv6 calls
for (String locale : badLocales) {
testCase = TestCaseHelper.buildBadRequestCase(SUBNETS_ENDPOINT_URL, new String[] { "ipv6", locale }, "");
testCase = TestCaseHelper.buildNotFoundCase(SUBNETS_ENDPOINT_URL, new String[] { "ipv6", locale }, "");
RestAssuredTemplates.testGet(testCase);
}
}
......@@ -79,7 +79,7 @@ public class SubnetResourceTest {
// check other permutations (regex endpoint)
for (String subnet : badSubnets) {
testCase = TestCaseHelper.buildBadRequestCase(SUBNETS_ENDPOINT_URL, new String[] { subnet, "ca" }, "");
testCase = TestCaseHelper.buildNotFoundCase(SUBNETS_ENDPOINT_URL, new String[] { subnet, "ca" }, "");
RestAssuredTemplates.testGet(testCase);
}
}
......
eclipse.maxmind.root=./tmp/maxmind
quarkus.jacoco.includes=**/geoip/**/*
\ No newline at end of file
......@@ -266,6 +266,18 @@ dependency-graph@~0.11.0:
resolved "https://registry.yarnpkg.com/dependency-graph/-/dependency-graph-0.11.0.tgz#ac0ce7ed68a54da22165a85e97a01d53f5eb2e27"
integrity sha512-JeMq7fEshyepOWDfcfHK06N3MhyPhz++vtqWhMT5O9A3K42rdsEDpfdVqjaqaAhsw6a+ZqeDvQVtD0hFHQWrzg==
eclipsefdn-api-support@1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/eclipsefdn-api-support/-/eclipsefdn-api-support-1.0.0.tgz#c8937b5ca0d78a8b40af893853a0f47dd6e9b5fd"
integrity sha512-SjhoMWW1JADNJzFd5cQhiYnFGctSNGvhc+U4AH+1/eHA/Qbcs7SatpHLn9pBNSHFq0JqYjLa+9yMznc3FrSJFA==
dependencies:
"@openapi-contrib/openapi-schema-to-json-schema" "^3.1.1"
"@redocly/openapi-cli" "^1.0.0-beta.54"
"@stoplight/json-ref-resolver" "^3.1.2"
decamelize "^5.0.0"
js-yaml "^4.1.0"
yargs "^17.0.1"
emoji-regex@^8.0.0:
version "8.0.0"
resolved "https://registry.yarnpkg.com/emoji-regex/-/emoji-regex-8.0.0.tgz#e818fd69ce5ccfcb404594f842963bf53164cc37"
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment