Skip to content
Snippets Groups Projects

feat: Improve code quality + upgrade to Common 1.0.0

1 unresolved thread
15 files
+ 560
164
Compare changes
  • Side-by-side
  • Inline
Files
15
@@ -14,7 +14,9 @@ package org.eclipsefoundation.mailing.dto;
import java.util.Date;
import java.util.Objects;
import org.eclipsefoundation.core.namespace.DefaultUrlParameterNames;
import org.apache.commons.lang3.StringUtils;
import org.eclipsefoundation.http.namespace.DefaultUrlParameterNames;
import org.eclipsefoundation.mailing.namespace.MailingListUrlParameterNames;
import org.eclipsefoundation.persistence.dto.BareNode;
import org.eclipsefoundation.persistence.dto.filter.DtoFilter;
import org.eclipsefoundation.persistence.model.DtoTable;
@@ -139,13 +141,13 @@ public class MailingListSubscriptions extends BareNode {
if (isRoot) {
// ID check
String id = params.getFirst(DefaultUrlParameterNames.ID.getName());
if (id != null) {
if (StringUtils.isNotBlank(id)) {
stmt.addClause(
new ParameterizedSQLStatement.Clause(TABLE.getAlias() + ".email = ?", new Object[] { id }));
}
// project ID check
String listName = params.getFirst("list_name");
if (listName != null) {
String listName = params.getFirst(MailingListUrlParameterNames.LIST_NAME.getName());
if (StringUtils.isNotBlank(listName)) {
stmt.addClause(new ParameterizedSQLStatement.Clause(TABLE.getAlias() + ".listName = ?",
new Object[] { listName }));
}
@@ -157,6 +159,5 @@ public class MailingListSubscriptions extends BareNode {
public Class<MailingListSubscriptions> getType() {
return MailingListSubscriptions.class;
}
}
}
Loading