Add initial implementation of API

added 1 commit

• d1b52792 - Remove OIDC configs from application

Compare with previous version

Feedback:

• Missing from the requirements is https://api.eclipse.org/#operation/MailingListSubscriptions. I am thinking that we can create a username filter such as http://localhost:8090/mailing_lists?username=cguindon then we should be able to create a proxy rule in Nginx for account/profile/:username/mailing-list => http://localhost:8090/mailing_lists?username=:username
• looking at the current implementation, we do not expose private mailing-list: https://gitlab.eclipse.org/eclipsefdn/it/webdev/drupal/eclipse_api/-/blob/7.x-1.x/resources/mailing_list.inc#L90
• Docker-compose files needs to be cleaned up. We don't need most of the services defined in that file.
• We shouldn't be using environment variables from REM: !1 (diffs)
• missing license file
• disabled property should be renamed to is_disabled to match the current spec
• deleted property should be renamed to is_deleted to match the current spec
• subscribable property should be renamed to is_subscribable to match the current spec
• deleted property should be renamed to is_deleted to match the current spec

Finally, I am noticing that we are introducing new properties in the spec:

• create_archives
• create_date
• created_by
• provision_status

I don't have any concerns with the date/created_by but let's check with @webmaster to make sure we are not exposing something that we would prefer to keep private.

@webmaster, do you have any issue with us exposing these new properties in our API mailing list?

"create_archives": true, "create_date": "0005-09-20T11:56:52Z", "created_by": "AUTOCREATE", "provision_status": "LC:ARC:RUNARC:SEARCH:{COMPLETED}",

I don't think there is anything particularly problematic with exposing this information.

But I do wonder if anyone(aside from maybe us) actually cares about the complete provision_status value(rather than a simple 'complete/pending') or the created_by(since ~98% will all have the same value).

If we care and it's not sensitive information, that's a good enough reason to expose it.

added 1 commit

• cd2bc688 - Add unit tests, add accounts lookup functionality

Compare with previous version

added 1 commit

• cfd98654 - Add k8s initial configuration files

Compare with previous version

added 1 commit

• 84441953 - Add meta info about project, update empty result to return 404

Compare with previous version

marked this merge request as ready

changed title from Draft: Add initial implementation to Add initial implementation of API

requested review from @cguindon, @fgurr, and @mbarbero

approved this merge request

mentioned in commit 947eb421

merged