fix: Fix error where GH pre-load crashes app if not data found

Resolves #24 (closed)

src/main/java/org/eclipsefoundation/cve/service/impl/DefaultCveService.java

@@ -159,7 +159,9 @@ public class DefaultCveService implements CveService {
 
             return om.readerFor(CveProjectData.class).readValue(githubApi.getCveDetails(params));
         } catch (Exception e) {
-            throw new RuntimeException(String.format("Could not fetch CVE %s from GitHub", key), e);
+            // Catch and log so as to not block the pre-load if GH has issues
+            LOGGER.error(String.format("Could not fetch CVE %s from GitHub", key), e);
+            return null;
         }
     }
 }

[Martin Lowe]

Do you handle the null upstream? We should also create a test case where the CVE details are null to prevent regression.

[Zachary Sabourin]

I haven't found any issues. Querying a CVE with no augmentable data just returns it with those fields as null