Skip to content
Snippets Groups Projects

Fix code smell around Boolean usage, reserved name usage, and boxing

12 files
+ 41
47
Compare changes
  • Side-by-side
  • Inline
Files
12
@@ -62,7 +62,7 @@ public final class CSRFHelper {
* @return the CSRF token for the current request.
*/
public String getSessionCSRFToken(AdditionalUserData aud, HttpServletRequest httpServletRequest) {
if (distributedMode.get()) {
if (Boolean.TRUE.equals(distributedMode.get())) {
return generator.getCSRFToken(httpServletRequest);
} else {
return aud.getCsrf();
@@ -107,12 +107,12 @@ public final class CSRFHelper {
}
private static boolean verifyConstantTime(String expectedToken, String token) {
if (expectedToken == token) {
return true;
}
if (expectedToken == null || token == null) {
return false;
}
if (expectedToken.equals(token)) {
return true;
}
return MessageDigest.isEqual(expectedToken.getBytes(StandardCharsets.US_ASCII),
token.getBytes(StandardCharsets.US_ASCII));
}
Loading