Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E eclipsefdn-api-common
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 13
    • Issues 13
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Eclipse FoundationEclipse Foundation
  • IT
  • APIs
  • eclipsefdn-api-common
  • Merge requests
  • !27

Fix issues with pagination not respecting pagesize, and recorder key gen

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Martin Lowe requested to merge malowe/eclipsefdn-api-common:malowe/master/limit-replacement into master Mar 14, 2022
  • Overview 0
  • Commits 2
  • Changes 7

Cache recorders were using pagination params as part of the unique key generation but this is incorrect. Using those keys led to bad matching as pagination params would not affect any of the current cache recorder results. This also meant some cases where defaults were set would generate keys that don't match outside of the cache.

Also added a ton of redundancy to referencing the response as it isn't always present.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: malowe/master/limit-replacement

Copyright © Eclipse Foundation, Inc. All Rights Reserved.     Privacy Policy | Terms of Use | Copyright Agent