Various code smell fixes from sonar

• Various code smell fixes from sonar

caching/src/main/java/org/eclipsefoundation/caching/service/impl/DefaultLoadingCacheManager.java

@@ -21,10 +21,6 @@ import java.util.concurrent.TimeUnit;
 import java.util.concurrent.TimeoutException;
 import java.util.stream.Collectors;
 
-import jakarta.annotation.PostConstruct;
-import jakarta.enterprise.context.ApplicationScoped;
-import jakarta.inject.Inject;
-
 import org.eclipse.microprofile.context.ManagedExecutor;
 import org.eclipsefoundation.caching.config.LoadingCacheConfig;
 import org.eclipsefoundation.caching.config.LoadingCacheConfig.LoaderDefinition;
@@ -38,10 +34,12 @@ import io.quarkus.arc.All;
 import io.quarkus.arc.InstanceHandle;
 import io.quarkus.runtime.Startup;
 import io.quarkus.scheduler.Scheduled;
+import jakarta.annotation.PostConstruct;
+import jakarta.enterprise.context.ApplicationScoped;
 
 /**
- * Service layer for defined loading caches. This centralizes the loading caches to reduce potential for inconsistent or
- * incorrect implementations of loading caches in downstream applications.
+ * Service layer for defined loading caches. This centralizes the loading caches to reduce potential for inconsistent or incorrect
+ * implementations of loading caches in downstream applications.
  * 
  * @author Martin Lowe
  *
@@ -50,18 +48,27 @@ import io.quarkus.scheduler.Scheduled;
 @ApplicationScoped
 public class DefaultLoadingCacheManager implements LoadingCacheManager {
 
-    @Inject
-    LoadingCacheConfig config;
-
-    @Inject
-    @All
-    List<InstanceHandle<LoadingCacheProvider<?>>> providers;
-    @Inject
-    ManagedExecutor executor;
+    private final LoadingCacheConfig config;
+    private final List<InstanceHandle<LoadingCacheProvider<?>>> providers;
+    private final ManagedExecutor executor;
 
     // internal list of managed loading caches
     private List<LoadingCacheWrapper<?>> caches;
 
+    /**
+     * Default constructor for LCM, includes required configs, providers, and the executor for processing.
+     * 
+     * @param config loading cache configuration mapping for runtime
+     * @param providers list of all available loaders for the cache
+     * @param executor context-aware executor for loading cache async
+     */
+    public DefaultLoadingCacheManager(LoadingCacheConfig config, @All List<InstanceHandle<LoadingCacheProvider<?>>> providers,
+            ManagedExecutor executor) {
+        this.config = config;
+        this.providers = providers;
+        this.executor = executor;
+    }
+
     /**
      * Using the loading cache providers, generate active loading caches for the application.
      */
@@ -104,8 +111,8 @@ public class DefaultLoadingCacheManager implements LoadingCacheManager {
     }
 
     /**
-     * Using the key and the discovered cache, do a lookup of the key, using the configured timeout and rethrowing any
-     * exceptions in execution upstream.
+     * Using the key and the discovered cache, do a lookup of the key, using the configured timeout and rethrowing any exceptions in
+     * execution upstream.
      * 
      * @param <T> the type of data returned by the cache
      * @param k the cache key to pass to the loading cache for value retrieval
@@ -133,13 +140,12 @@ public class DefaultLoadingCacheManager implements LoadingCacheManager {
     }
 
     /**
-     * Checks if a cache should be refreshed by checking the last refresh time, and if so iterating all active keys and
-     * attempt a refresh. This is used for cases where we need to force the cache to refresh before it is called by
-     * downstream methods to have the most accurate data possible.
+     * Checks if a cache should be refreshed by checking the last refresh time, and if so iterating all active keys and attempt a refresh.
+     * This is used for cases where we need to force the cache to refresh before it is called by downstream methods to have the most
+     * accurate data possible.
      */
     @Scheduled(every = "5m")
     void refreshKeys() {
-        // TODO we'll want to maintain a map of last refresh times to reduce unnecessary operations
         caches
                 .stream()
                 .filter(wrapper -> wrapper.config.forceRefresh())
@@ -166,8 +172,8 @@ public class DefaultLoadingCacheManager implements LoadingCacheManager {
     }
 
     /**
-     * Typed generic wrapper for loading caches. This will help match on internal types of expected output and increase type
-     * safety around lookups, as well as provide best matching configuration values for the given cache.
+     * Typed generic wrapper for loading caches. This will help match on internal types of expected output and increase type safety around
+     * lookups, as well as provide best matching configuration values for the given cache.
      * 
      * @author Martin Lowe
      *
@@ -179,8 +185,8 @@ public class DefaultLoadingCacheManager implements LoadingCacheManager {
         private final LoaderDefinition config;
 
         /**
-         * Builds the wrapper with assembled cache, the configurations that apply to the cache to reduce need for reflection,
-         * and the internal type for easier matching on incoming requests.
+         * Builds the wrapper with assembled cache, the configurations that apply to the cache to reduce need for reflection, and the
+         * internal type for easier matching on incoming requests.
          * 
          * @param cache the wrapped asynchronous cache
          * @param innerType the return type of the loading cache
@@ -202,8 +208,8 @@ public class DefaultLoadingCacheManager implements LoadingCacheManager {
         }
 
         /**
-         * Retrieves a view of the cache keys for the current cache. Will only show keys that have realized values and not
-         * values that are in the process of being fetched.
+         * Retrieves a view of the cache keys for the current cache. Will only show keys that have realized values and not values that are
+         * in the process of being fetched.
          * 
          * @return list of cache keys for finished cache results.
          */
@@ -221,8 +227,8 @@ public class DefaultLoadingCacheManager implements LoadingCacheManager {
         }
 
         /**
-         * Gets the pre-loading cache configuration that defines refresh periods, whether to enforce forced refreshes, and the
-         * timeout periods to reduce risk of stalled operations.
+         * Gets the pre-loading cache configuration that defines refresh periods, whether to enforce forced refreshes, and the timeout
+         * periods to reduce risk of stalled operations.
          * 
          * @return the preloading configuration for the wrapped cache.
          */