Fix issue with cache param map leaks, add fuzzy remove tests

Param maps weren't being properly cloned before being used as the keys, meaning that the key could be modified after being used. This led to some weird behaviour where keys would duplicate themselves.

Additionally added some fuzzy key removal tests to validate the functionality as there were some issues in a downstream project that used the call. There were no issues in code for fuzzyRemove, so it was left unchanged.

core/src/main/java/org/eclipsefoundation/core/service/impl/QuarkusCachingService.java

@@ -53,7 +53,7 @@ import io.quarkus.cache.CaffeineCache;
 @ApplicationScoped
 public class QuarkusCachingService implements CachingService {
     private static final Logger LOGGER = LoggerFactory.getLogger(QuarkusCachingService.class);
-    
+
     @ConfigProperty(name = MicroprofilePropertyNames.CACHE_TTL_MAX_SECONDS, defaultValue = "900")
     long ttlWrite;
 
@@ -67,13 +67,8 @@ public class QuarkusCachingService implements CachingService {
     @Override
     public <T> Optional<T> get(String id, MultivaluedMap<String, String> params, Class<?> rawType, Callable<? extends T> callable) {
         Objects.requireNonNull(callable);
-
-        ParameterizedCacheKey cacheKey = ParameterizedCacheKey
-                .builder()
-                .setClazz(rawType)
-                .setId(id)
-                .setParams(params != null ? params : new MultivaluedMapImpl<>())
-                .build();
+        // create the cache key for the entry, cloning the map for key integrity
+        ParameterizedCacheKey cacheKey = ParameterizedCacheKey.builder().setClazz(rawType).setId(id).setParams(cloneMap(params)).build();
         LOGGER.debug("Retrieving cache value for '{}'", cacheKey);
         return Optional.ofNullable(get(cacheKey, callable));
     }
@@ -167,7 +162,7 @@ public class QuarkusCachingService implements CachingService {
     }
 
     @CacheResult(cacheName = "default")
-    public <T> T get(@CacheKey ParameterizedCacheKey cacheKey, Callable<? extends T> callable) {
+    <T> T get(@CacheKey ParameterizedCacheKey cacheKey, Callable<? extends T> callable) {
         // attempt to get the result for the cache entry
         T out = null;
         try {
@@ -189,4 +184,18 @@ public class QuarkusCachingService implements CachingService {
         return System.currentTimeMillis() + getMaxAge();
     }
 
+    /**
+     * To prevent modification of maps/cache key entries post retrieval, we should be referencing copies of the maps rather
+     * than the direct passed reference for safety.
+     * 
+     * @return the copied map, or an empty map if null
+     */
+    private MultivaluedMap<String, String> cloneMap(MultivaluedMap<String, String> paramMap) {
+        MultivaluedMap<String, String> out = new MultivaluedMapImpl<>();
+        if (paramMap != null) {
+            paramMap.entrySet().forEach(e -> out.addAll(e.getKey(), e.getValue()));
+        }
+        return out;
+    }
+
 }