Skip to content
Snippets Groups Projects

Draft: Write Interface for Graph DB

Closed Cristina Pauna requested to merge feature/UploadSDInterface/GraphDB into main
3 unresolved threads

Dear Team, Please check the Upload SD Interface Best Wishes Nikhil

Edited by Cristina Pauna

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
1 package eu.gaiax.difs.fc.core.service.graphdb;
2
3 import eu.gaiax.difs.fc.core.pojo.SdClaim;
4
5 import java.util.List;
6
7 public interface SDGraphStore {
  • 1 package eu.gaiax.difs.fc.core.service.graphdb;
    2
    3 import eu.gaiax.difs.fc.core.pojo.SdClaim;
    4
    5 import java.util.List;
    6
    7 public interface SDGraphStore {
    8
    9
    10 /**
    11 * Pushes set of claims to the Graph db. The set of claims are list of claim
    12 * object containing subject, predicate and object in the form of ntriples
    13 * format stored in individual strings.
    14 *
    15 * @param sdClaimList List of claims to add to the Graph DB.
    16 * @return String SUCCESS or FAIL
    • Please not! Never return the successful or not as String!

      I think it's enough to throw an exception if the the update failed.

      By phertweck on 2022-08-19T09:53:27 (imported from GitLab)

    • Please register or sign in to reply
  • 3 import eu.gaiax.difs.fc.core.pojo.SdClaim;
    4
    5 import java.util.List;
    6
    7 public interface SDGraphStore {
    8
    9
    10 /**
    11 * Pushes set of claims to the Graph db. The set of claims are list of claim
    12 * object containing subject, predicate and object in the form of ntriples
    13 * format stored in individual strings.
    14 *
    15 * @param sdClaimList List of claims to add to the Graph DB.
    16 * @return String SUCCESS or FAIL
    17 */
    18 public String uploadSelfDescription(List<SdClaim> sdClaimList);
    • I'd suggest renaming it to addClaims, since your accepting Claims and not and SD (we need to be very precise on this).

      Is it easier for you, if we directly pass the credentialSubject into this method, like discussed yesterday?

      By phertweck on 2022-08-19T09:53:27 (imported from GitLab)

    • Please register or sign in to reply
  • Please register or sign in to reply
    Loading