increased gcc warning levels reveal some potential casting issues
Submitted by Kristof Szabados
Link to original bug (#504053)
Description
After reading an interesting publication (https://www.researchgate.net/publication/308791357_Twice_the_Bits_Twice_the_Trouble_Vulnerabilities_Induced_by_Migrating_to_64-Bit_Platforms) on what can go wrong when C/C++ code designed for 32 bit systems is used on 64 systems I checked what the methods mentioned in the article would result in on titan.
Wsign-compare: 29 pieces Wsign-conversion: ~5900 pieces Wfloat-conversion: ~600 pieces Wconversion: ~3000 pieces
Most of the found issues are harmless and correction would not result in faster operation. Yet it would be a good idea to check and try to correct them to have a cleaner code and forego potential issues later.
Version: 5.5.0