Skip to content
Snippets Groups Projects
Commit 7feafddd authored by Kristof Szabados's avatar Kristof Szabados
Browse files

fix memoryleaks in JUnitLogge rand JUnitLogger2


This is likely a copy+paste mistake that has been lurking around
for quite some time.

(fix originally made by Harald Welte)

Signed-off-by: default avatarKristof Szabados <Kristof.Szabados@ericsson.com>
parent f95d6bae
No related branches found
No related tags found
No related merge requests found
......@@ -86,7 +86,7 @@ void JUnitLogger::set_parameter(
Free(filename_stem_);
filename_stem_ = mcopystr(parameter_value);
} else if (!strcmp("testsuite_name", parameter_name)) {
if (filename_stem_ != NULL)
if (testsuite_name_ != NULL)
Free(testsuite_name_);
testsuite_name_ = mcopystr(parameter_value);
} else {
......
......@@ -83,7 +83,7 @@ void JUnitLogger2::set_parameter(const char *parameter_name, const char *paramet
Free(filename_stem_);
filename_stem_ = mcopystr(parameter_value);
} else if (!strcmp("testsuite_name", parameter_name)) {
if (filename_stem_ != NULL)
if (testsuite_name_ != NULL)
Free(testsuite_name_);
testsuite_name_ = mcopystr(parameter_value);
} else {
......@@ -236,13 +236,6 @@ void TestCase::writeTestCase(FILE* file_stream_) const{
fprintf(file_stream_, " <error type='DTE'>%s</error>\n", dte_reason.data());
fprintf(file_stream_, " </testcase>\n");
break; }
case Inconc: {
fprintf(file_stream_, " <testcase classname='%s' name='%s' time='%f'>\n", module_name.data(), tc_name.data(), time);
fprintf(file_stream_, " <failure type='inconclusive-verdict'>%s\n", reason.data());
fprintf(file_stream_, "%s\n", stack_trace.data());
fprintf(file_stream_, " </failure>\n");
fprintf(file_stream_, " </testcase>\n");
break; }
default:
fprintf(file_stream_, " <testcase classname='%s' name='%s' time='%f'/>\n", module_name.data(), tc_name.data(), time);
break;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment