Skip to content
Snippets Groups Projects
Commit dba34ac5 authored by Kristof Szabados's avatar Kristof Szabados
Browse files

some more method arguments could be made final.


Signed-off-by: default avatarkristof <Kristof.Szabados@ericsson.com>
parent e460f3f5
No related branches found
No related tags found
No related merge requests found
......@@ -78,7 +78,7 @@ public enum CodeSmellType implements ProblemType{
private String innerName;
private String readableName;
private CodeSmellType(String name, Double minTime, Double avgTime, Double maxTime) {
private CodeSmellType(final String name, final Double minTime, final Double avgTime, final Double maxTime) {
this.defaultMinTime = minTime;
this.defaultAvgTime = avgTime;
this.defaultMaxTime = maxTime;
......
......@@ -22,24 +22,24 @@ public class ProblemNameToPreferenceMapper {
private static final String MAX = ".MAX";
private static final String TIME= " .TIME";
public static String nameSmellAvgTime(String smellName) {
public static String nameSmellAvgTime(final String smellName) {
return smellName + AVG + TIME;
}
public static String nameSmellMinTime(String smellName) {
public static String nameSmellMinTime(final String smellName) {
return smellName + MIN +TIME;
}
public static String nameSmellMaxTime(String smellName) {
public static String nameSmellMaxTime(final String smellName) {
return smellName + MAX +TIME;
}
// Some aid method to make accessing code smell data easier:
public static String nameSmellImpact(String smellName) {
public static String nameSmellImpact(final String smellName) {
return smellName + IMPACT;
}
public static String nameSmellBaseLine(String smellName) {
public static String nameSmellBaseLine(final String smellName) {
return smellName + BASELINE;
}
}
......@@ -22,14 +22,14 @@ public enum TaskType implements ProblemType{
//TODO What are the default times?
FIXME("FIXME tags", 0.0, 0.0, 0.0) {
@Override
public boolean equalType(IMarker m) throws CoreException {
public boolean equalType(final IMarker m) throws CoreException {
return IMarker.PRIORITY_HIGH == m.getAttribute(IMarker.PRIORITY, IMarker.PRIORITY_LOW);
}
},
//TODO What are the default times?
TODO("TODO tags", 0.0, 0.0, 0.0) {
@Override
public boolean equalType(IMarker m) throws CoreException {
public boolean equalType(final IMarker m) throws CoreException {
return IMarker.PRIORITY_NORMAL == m.getAttribute(IMarker.PRIORITY, IMarker.PRIORITY_LOW);
}
};
......@@ -41,7 +41,7 @@ public enum TaskType implements ProblemType{
private String readableName;
private String innerName;
TaskType(String name, Double minTime, Double avgTime, Double maxTime) {
TaskType(final String name, final Double minTime, final Double avgTime, final Double maxTime) {
readableName = name;
defaultMinTime = minTime;
defaultAvgTime = avgTime;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment