#179 - PCM Configs Generator doesn’t create the ProfilesCatalog( ver 0.4.8)
All threads resolved!
Merged
requested to merge victorhexad/simopenpass:pcm-generator-doesnt-create-profilecatalog-schema0.4.8 into develop
All threads resolved!
Merge request reports
Activity
Filter activity
Looks good to me, I compared it with the PCM example in the E2E test case
requested review from @rbiegel
added 1 commit
- 71103225 - Update XmlProfilesConfig.cpp 4 spaces indentation std
- Resolved by Reinhard Biegel
Thx! When building opSimulation with MinGW, I had to fix this error (missing include !102 (closed) )
Could you integrate this pending fix in your MR so it finally ends up on
develop, too? - Last reply by Reinhard Biegel
mentioned in issue #179 (closed)
added 1 commit
- f14f18b1 - Update pcm_definitions.h adding #include <array>
- Resolved by Reinhard Biegel
I think is done, BUT please take into account that ECA is required if i'm not mistaken, Adding logs here from my prompt:
Click to expand logs from the prompt
Counting objects: 100% (13/13), done. Delta compression using up to 10 threads Compressing objects: 100% (7/7), done. Writing objects: 100% (7/7), 668 bytes | 668.00 KiB/s, done. Total 7 (delta 5), reused 1 (delta 0), pack-reused 0 remote: Fork detected, using forked from project's URL for better commit validation. remote: Commit: f14f18b15ff6d5a35c875debea6060856a61817d X remote: remote: Reviewing commit: f14f18b15ff6d5a35c875debea6060856a61817d remote: Authored by: Marcello Montanino <marcello.montanino@outlook.com> remote: Eclipse user 'm121212'(author) is not a committer on the project. remote: Eclipse user 'm121212'(author) does not have a current Eclipse Contributor Agreement (ECA) on file. remote: If there are multiple commits, please ensure that each author has a ECA. remote: Eclipse user 'victorhexad'(committer) is not a committer on the project. remote: Eclipse user 'victorhexad'(committer) has a current Eclipse Contributor Agreement (ECA) on file. remote: remote: Errors: remote: An Eclipse Contributor Agreement is required for Eclipse user 'm121212'(author). remote: Any warnings or errors noted above may indicate compliance issues with committer ECA requirements. More information may be found on https://www.eclipse.org/legal/ECA.php remote: remote: remote: GL-HOOK-ERR: More information is available at https://api.eclipse.org/git/eca/status/e7d13080a7b62e5bd3b027ef11e9bb4e/ui remote: Errors detected, but commits will be allowed for forked repository. Commit errors reported in this push will block merge into origin repository until resolved. remote: remote: View merge request for pcm-generator-doesnt-create-profilecatalog-schema0.4.8: remote: https://gitlab.eclipse.org/eclipse/openpass/opSimulation/-/merge_requests/106 remote: To https://gitlab.eclipse.org/victorhexad/simopenpass.git 71103225..f14f18b1 HEAD -> pcm-generator-doesnt-create-profilecatalog-schema0.4.8 ➜ simopenpass git:(f14f18b1) </details> - Last reply by Reinhard Biegel
mentioned in commit 45b39cbd
Please register or sign in to reply