PCM Configs Generator doesn’t create the ProfilesCatalog( ver 0.4.8)

The issue was that the code wrotes a wrong version number and openPASS declined the config files because of the outdated version number.

Please assign this task to me, I can upload the fix

assigned to @victorhexad

This PCM specific ProfileCatalog is written by the GUI, so it should be moved to the issue list in the subrepo opGUI

You’re absolute correct on this, but since the GUI is not separated yet, we think it could be better to apply the changes here, and later on when the gui is migrated to the other repository we can start opening GUI related issues there

Could someone please create a branch from the dev branch to push the changes to the repository?

Thank you so much

changed milestone to %Release v1.0.0

set weight to 1

mentioned in merge request !106 (merged)

Clarification needed for MR !106 (merged) @victorhexad

mentioned in commit 45b39cbd

@rbiegel I just realized that the latest CI build (Windows, openPASS_SIM.zip) still contains the PCM_sim.dll GUI plugin before MR !106 (merged) - hence, the plugin still generates ProfileCatalogv0.4.6 (required: v0.4.12)

assigned to @jdobberstein

changed milestone to %Release v0.11

omg ... that's serious :-(

Looks like it's a combination of two issues:

1. On the latest develop build, the "make install" step is missing the installation of the GUI completely. Expected output would look like this (taken from older build log):

-- Installing: W:/dist/opSimulation/gui/Component.dll
-- Installing: W:/dist/opSimulation/gui/Pcm_eval.dll
-- Installing: W:/dist/opSimulation/gui/Pcm_sim.dll
-- Installing: W:/dist/opSimulation/gui/Project.dll

Reason: unknown

2. Due to incomplete cleanup step, the dist folder isn't wiped during setup of a new build -> old GUI files might still reside in the directory, which will ultimately be packed into the zip artifact.

@jdobberstein: I'll create issues for that. 2. is rather clear. Is 1. maybe already covered by one of the recently updated GUI stories?

Side note: Your wrote about versions 0.4.6 vs. 0.4.12, but the mentioned MR only updates to 0.4.8.

mentioned in issue #207 (closed)

Thx for looking into this! I assumed that the GUI was left out due to the build error (missing include)

Regarding the 0.4.12: when Victor openened the issue, the intention was to update the GUI to version v0.4.8

Now, we need v0.4.12 - and this tiny change is all we need to do to start a PCM simulation from the GUI with the current core.

I assigned the issue to me, since we are working on several minor fixes we are about to commit for v0.11

mentioned in merge request !128 (merged)

closed