Skip to content
Snippets Groups Projects
Commit 523df5c1 authored by Francesco Pham's avatar Francesco Pham
Browse files

openharmony-standard: add patch to fix segfault problem


Adding and apply ParagraphTxt-ComputeLineBreaks-skip-sigsegv-code.patch

ParagraphTxt::ComputeLineBreaks() is causing a segmentation fault for some 
reasons. This is causing hap applications to crash, including ACTS test suites
and status bar.
As a temporary solution we skip the part of the code that
is raising the segfault. The side effect of this is that texts are 
not properly rendered.

Signed-off-by: default avatarFrancesco Pham <francesco.pham@huawei.com>
parent 460feb6b
No related branches found
No related tags found
1 merge request!101openharmony-standard: add patches to fix segfault, disable graphics, fixing feature abilities timeouts
# SPDX-FileCopyrightText: Huawei Inc.
#
# SPDX-License-Identifier: Apache-2.0
ParagraphTxt::ComputeLineBreaks() is causing a segmentation fault for some reasons.
This is causing hap applications to crash, including ACTS test suites
and status bar.
As a temporary solution we skip the part of the code that
is raising the segfault. The side effect of this is that texts are
not properly rendered.
Apply to third_party/flutter
Upstream-Status: Inappropriate
Signed-off-by: Francesco Pham <francesco.pham@huawei.com>
diff --git a/engine/flutter/third_party/txt/src/txt/paragraph_txt.cc b/engine/flutter/third_party/txt/src/txt/paragraph_txt.cc
index 49594991..ed22d885 100644
--- a/engine/flutter/third_party/txt/src/txt/paragraph_txt.cc
+++ b/engine/flutter/third_party/txt/src/txt/paragraph_txt.cc
@@ -250,6 +250,10 @@ void ParagraphTxt::SetInlinePlaceholders(
}
bool ParagraphTxt::ComputeLineBreaks() {
+
+ // skipping ComputeLineBreaks execution because it is source of segfault problems.
+ return true;
+
line_ranges_.clear();
line_widths_.clear();
max_intrinsic_width_ = 0;
# SPDX-FileCopyrightText: Huawei Inc.
#
# SPDX-License-Identifier: Apache-2.0
RenderText::PerformLayout() is causing a SIGSEGV for some reasons.
The error appears to be raised in the Measure method(). This is
causing hap applications to crash, including ACTS test suites.
As a temporary solution we are removing the part of the code that
is raising the segfault. The side effect of this is that texts are
not properly rendered.
Apply to foundation/ace/ace_engine
Signed-off-by: Francesco Pham <francesco.pham@huawei.com>
Upstream-Status: Inappropriate
diff --git a/frameworks/core/components/text/render_text.cpp b/frameworks/core/components/text/render_text.cpp
index f3135d3c..813d6179 100644
--- a/frameworks/core/components/text/render_text.cpp
+++ b/frameworks/core/components/text/render_text.cpp
@@ -133,8 +133,8 @@ void RenderText::PerformLayout()
if (pipelineContext) {
UpdateIfChanged(dipScale_, pipelineContext->GetDipScale());
}
- Size size = Measure();
- SetLayoutSize(GetLayoutParam().Constrain(size));
+ // Size size = Measure();
+ // SetLayoutSize(GetLayoutParam().Constrain(size));
for (const auto& spanChild : GetChildren()) {
if (spanChild) {
const auto& param = GetLayoutParam();
...@@ -72,7 +72,7 @@ SRC_URI += "file://base_hiviewdfx_hiview-libfaultlogger-static.patch;patchdir=${ ...@@ -72,7 +72,7 @@ SRC_URI += "file://base_hiviewdfx_hiview-libfaultlogger-static.patch;patchdir=${
# Patch to allow /system/profile and /system/usr to be symlinks to /usr/lib/openharmony # Patch to allow /system/profile and /system/usr to be symlinks to /usr/lib/openharmony
SRC_URI += "file://foundation_distributedschedule_safwk-slash-system-symlink.patch;patchdir=${S}/foundation/distributedschedule/safwk" SRC_URI += "file://foundation_distributedschedule_safwk-slash-system-symlink.patch;patchdir=${S}/foundation/distributedschedule/safwk"
SRC_URI += "file://RenderText-PerformLayout-remove-sigsegv-code.patch;patchdir=${S}/foundation/ace/ace_engine" SRC_URI += "file://ParagraphTxt-ComputeLineBreaks-skip-sigsegv-code.patch;patchdir=${S}/third_party/flutter"
SRC_URI += "file://test-xts-acts-timeout-increment.patch;patchdir=${S}/test/xts/acts" SRC_URI += "file://test-xts-acts-timeout-increment.patch;patchdir=${S}/test/xts/acts"
SRC_URI += "file://start-ability-timeout-increment.patch;patchdir=${S}/test/xts/acts" SRC_URI += "file://start-ability-timeout-increment.patch;patchdir=${S}/test/xts/acts"
SRC_URI += "file://test-xts-acts-fix-Defpermission-typo.patch;patchdir=${S}/test/xts/acts" SRC_URI += "file://test-xts-acts-fix-Defpermission-typo.patch;patchdir=${S}/test/xts/acts"
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment