Skip to content
Snippets Groups Projects

CI: cleanup Linux jobs

Open Davide Gardenal requested to merge tony3oo3/oniro:tony/CI_linux_cleanup into kirkstone
2 unresolved threads

The parent of all Linux jobs is now unified to enable easier extensibility later on.
Update documentation.

Signed-off-by: Davide Gardenal davide.gardenal@huawei.com

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Davide Gardenal resolved all threads

    resolved all threads

  • added 1 commit

    • eb130b27 - .oniro-ci: add new Linux hidden job definition

    Compare with previous version

  • Davide Gardenal added 2 commits

    added 2 commits

    • 77e5b2f9 - 1 commit from branch eclipse/oniro-core:kirkstone
    • c8df46e8 - .oniro-ci: add new Linux hidden job definition

    Compare with previous version

  • added 1 commit

    • 5746c87e - .oniro-ci: add new Linux hidden job definition

    Compare with previous version

  • Davide Gardenal mentioned in issue #148

    mentioned in issue #148

  • Davide Gardenal added 4 commits

    added 4 commits

    Compare with previous version

  • Davide Gardenal added 16 commits

    added 16 commits

    Compare with previous version

  • Pawel Stankiewicz approved this merge request

    approved this merge request

  • Marta Rybczynska approved this merge request

    approved this merge request

  • Davide Gardenal added 8 commits

    added 8 commits

    Compare with previous version

  • Davide Gardenal added 2 commits

    added 2 commits

    • f67b48a9 - 1 commit from branch eclipse/oniro-core:kirkstone
    • d5b19354 - .oniro-ci: add new Linux hidden job definition

    Compare with previous version

  • Marta Rybczynska resolved all threads

    resolved all threads

  • @pastanki , @zyga is out for one more week. Do we merge it?

  • @zyga could you have a look please?

  • 276 277 # build and boot.
    277 278 - find "$BITBAKE_DEPLOY_DIR"/images/ -name *.wic -exec rm -rf {} \;
    278 279 - cp -a "$BITBAKE_DEPLOY_DIR"/licenses/ "$CI_PROJECT_DIR"/artifacts || true
    279 # Only copy the files defined in the CI_ONIRO_JOB_ARTIFACTS variable. Most
    280 # If CI_ONIRO_STORE_IMAGE_ARTIFACT is 1 copy the files defined in the CI_ONIRO_JOB_ARTIFACTS variable. Most
    280 281 # of the remaining files are redundant and quite large.
    282 - if test "$CI_ONIRO_STORE_IMAGE_ARTIFACT" != "1"; then (echo "CI_ONIRO_STORE_IMAGE_ARTIFACT is not set, artifacts will not be saved!") fi
    • I would re-phrase this and alter the shell style a little.

      Suggested change
      282 - if test "$CI_ONIRO_STORE_IMAGE_ARTIFACT" != "1"; then (echo "CI_ONIRO_STORE_IMAGE_ARTIFACT is not set, artifacts will not be saved!") fi
      282 - if [ "${CI_ONIRO_STORE_IMAGE_ARTIFACT:-}" != "1" ]; then echo "NOTE: Set CI_ONIRO_STORE_IMAGE_ARTIFACT=1 to archive built images, this is expensive, use only when the images are really consumed"; fi
    • Please register or sign in to reply
  • 302 304 variables:
    303 305 CI_ONIRO_BB_LOCAL_CONF_plus_equals_INHERIT: create-spdx
    304 306 CI_ONIRO_JOB_ARTIFACTS: "*.wic.* *.bmap"
    307 CI_ONIRO_STORE_IMAGE_ARTIFACT: 1
    • At the cost of being repetitive, can we move that to the jobs that really need it? In addition leave a comment why it is needed (e.g., consumed by job foo downstream).

    • Please register or sign in to reply
  • @zyga any ETA for that?

  • Please register or sign in to reply
    Loading