qemu-x86-64 won't boot with sudo installed

The module affected

oniro-image-base and sudo.

What is the action to reproduce the bug?

List of commands to reproduce the issue:

1. mkdir sudo_test; cd sudo_test
2. repo init -u https://gitlab.eclipse.org/eclipse/oniro-core/oniro.git -b kirkstone
3. repo sync --no-clone-bundle
4. TEMPLATECONF=../oniro/flavours/linux . ./oe-core/oe-init-build-env build-oniro-linux
5. echo "IMAGE_INSTALL += \"sudo\"" >> conf/local.conf
6. MACHINE=qemux86-64 bitbake oniro-image-base
7. MACHINE=qemux86-64 runqemu oniro-image-base wic ovmf kvm slirp nographic

What is the result you see?

UEFI Interactive Shell v2.2
EDK II
UEFI v2.70 (EDK II, 0x00010000)
Mapping table
      FS0: Alias(s):HD0a0b:;BLK1:
          PciRoot(0x0)/Pci(0x4,0x0)/Scsi(0x0,0x0)/HD(1,GPT,844416B3-1109-4CFF-AE0C-018A78E267BB,0x2000,0x100000)
     BLK0: Alias(s):
          PciRoot(0x0)/Pci(0x4,0x0)/Scsi(0x0,0x0)
     BLK2: Alias(s):
          PciRoot(0x0)/Pci(0x4,0x0)/Scsi(0x0,0x0)/HD(2,GPT,187F52E8-7410-47F8-99BB-0D28D4EABF24,0x102000,0x200000)
     BLK3: Alias(s):
          PciRoot(0x0)/Pci(0x4,0x0)/Scsi(0x0,0x0)/HD(3,GPT,58371765-29D5-4068-BB8B-1518D101168D,0x302000,0x200000)
     BLK4: Alias(s):
          PciRoot(0x0)/Pci(0x4,0x0)/Scsi(0x0,0x0)/HD(4,GPT,C8DBDFCC-E3EB-497C-AC79-32F9A1062218,0x502000,0x4000)
     BLK5: Alias(s):
          PciRoot(0x0)/Pci(0x4,0x0)/Scsi(0x0,0x0)/HD(5,GPT,BE41F32F-BC9A-4A56-99BA-A4E741D6293B,0x506000,0x100000)
     BLK6: Alias(s):
          PciRoot(0x0)/Pci(0x4,0x0)/Scsi(0x0,0x0)/HD(6,GPT,E413FEEB-7115-4AD1-8509-62960AAA7F26,0x606000,0x200000)






Shell> SC in 1 seconds to skip startup.nsh or any other key to continue.

What is the result you expect?

Successful boot and login prompt.

Frequency?

Always.

Tested version

Image: oniro-image-base
Flavour: linux

Do you know any workaround of this issue?

No.

Do you have a fix for this issue?

No.

added IssueBug needs-investigation teammaintenance labels

assigned to @landgraf

Build Configuration:
BB_VERSION           = "2.0.0"
BUILD_SYS            = "x86_64-linux"
NATIVELSBSTRING      = "universal"
TARGET_SYS           = "x86_64-oniro-linux-musl"
MACHINE              = "qemux86-64"
DISTRO               = "oniro-linux"
DISTRO_VERSION       = "2.0.0-alpha"
TUNE_FEATURES        = "m64 core2"
TARGET_FPU           = ""
meta-oniro-staging   = "HEAD:b0a7019476efd0324a41eb895d8bde96c91901fb"
meta                 = "HEAD:0f7a8359ba370c7f5d5153453ed699e9566f5b1d"
meta-arm             
meta-arm-toolchain   = "HEAD:a8cb33d5139e30b4a643da9a277487299c0e658f"
meta-clang           = "HEAD:72187036fe88850fe1a89fb4a3d53d2134680ccf"
meta-zephyr-bsp      
meta-zephyr-core     = "HEAD:df59d82772fd67b8fc1d30d97917305be0f49675"
meta-oniro-core      = "HEAD:b0a7019476efd0324a41eb895d8bde96c91901fb"
meta-freertos        = "HEAD:98a6838261d36b8f79c5fbae1736492169727a1e"
meta-intel           = "HEAD:8e472da759cd5a5bf2ece041d2796db56b1d5482"
meta-seco-intel      = "HEAD:65a673560211b11986db5785c70254fad190785f"
meta-freescale       = "HEAD:92df6b76f38397b75ea76d588935b5b91b63c58c"
meta-seco-imx        = "HEAD:b82eaf8b0a2abe775c158b0a069b7bb7894ec8e6"
meta-oe              
meta-filesystems     
meta-networking      
meta-perl            
meta-python          = "HEAD:fcc7d7eae82be4c180f2e8fa3db90a8ab3be07b7"
meta-raspberrypi     = "HEAD:0135a02ea577bd39dd552236ead2c5894d89da1d"
meta-security        = "HEAD:d3d8e62bf1caa3870a504c0addcfd200b33c189f"
meta-riscv           = "HEAD:70e099d7ceca52a1dde2c978713012f6b20a9891"
meta-rauc            = "HEAD:4429bd1f29677c9a7de032d53240fb4791a41e1f"

@tony3oo3 please use IMAGE_INSTALL::append = "sudo" as a workaround...

With IMAGE_INSTALL:append the result is: IMAGE_INSTALL=" packagegroup-core-boot packagegroup-base-extended sudo packagegroup-oniro-core packagegroup-net-essentials packagegroup-ble-essentials sysota rauc-hawkbit-updater kernel-image "

With IMAGE_INSTALL += "sudo" it's evaluated to:

IMAGE_INSTALL=" sudo packagegroup-oniro-core packagegroup-net-essentials packagegroup-ble-essentials sysota rauc-hawkbit-updater kernel-image

which is definitely wrong and causes the issue

Bad

# $IMAGE_INSTALL [7 operations]
#   append /mnt/builds/oniroproject/XXXXXX/build-oniro-linux/conf/local.conf:263
#     "sudo"
#   set /mnt/builds/oniroproject/XXXXXX/oe-core/meta/conf/documentation.conf:217
#     [doc] "Specifies the packages to install into an image. Image recipes set IMAGE_INSTALL to specify the packages to install into an image through image.bbclass."
#   set? /mnt/builds/oniroproject/XXXXXX/oe-core/meta/classes/core-image.bbclass:77
#     "${CORE_IMAGE_BASE_INSTALL}"
#   set? /mnt/builds/oniroproject/XXXXXX/oe-core/meta/classes/image.bbclass:78
#     ""
#   set /mnt/builds/oniroproject/XXXXXX/oe-core/meta/classes/image.bbclass:79
#     [type] "list"
#   :append /mnt/builds/oniroproject/XXXXXX/oe-core/../oniro/meta-oniro-core/recipes-core/images/oniro-image-common.inc:20
#     "         packagegroup-oniro-core             packagegroup-net-essentials             packagegroup-ble-essentials             sysota          rauc-hawkbit-updater            kernel-image            "
#   :append /mnt/builds/oniroproject/XXXXXX/oe-core/../oniro/meta-oniro-core/recipes-core/images/oniro-image-common.inc:22
#     " ${@bb.utils.contains('MACHINE_FEATURES', 'optee', 'optee-client', '', d)} "
# pre-expansion value:
#   " sudo          packagegroup-oniro-core             packagegroup-net-essentials             packagegroup-ble-essentials             sysota          rauc-hawkbit-updater            kernel-image             ${@bb.utils.contains('MACHINE_FEATURES', 'optee', 'optee-client', '', d)} "
IMAGE_INSTALL=" sudo            packagegroup-oniro-core             packagegroup-net-essentials             packagegroup-ble-essentials             sysota          rauc-hawkbit-updater            kernel-image              "
#

Good:

# $IMAGE_INSTALL [7 operations]
#   :append /mnt/builds/oniroproject/sudofail/build-oniro-linux/conf/local.conf:262
#     "sudo"
#   set /mnt/builds/oniroproject/sudofail/oe-core/meta/conf/documentation.conf:217
#     [doc] "Specifies the packages to install into an image. Image recipes set IMAGE_INSTALL to specify the packages to install into an image through image.bbclass."
#   set? /mnt/builds/oniroproject/sudofail/oe-core/meta/classes/core-image.bbclass:77
#     "${CORE_IMAGE_BASE_INSTALL}"
#   set? /mnt/builds/oniroproject/sudofail/oe-core/meta/classes/image.bbclass:78
#     ""
#   set /mnt/builds/oniroproject/sudofail/oe-core/meta/classes/image.bbclass:79
#     [type] "list"
#   :append /mnt/builds/oniroproject/sudofail/oe-core/../oniro/meta-oniro-core/recipes-core/images/oniro-image-common.inc:20
#     "         packagegroup-oniro-core             packagegroup-net-essentials             packagegroup-ble-essentials             sysota          rauc-hawkbit-updater            kernel-image            "
#   :append /mnt/builds/oniroproject/sudofail/oe-core/../oniro/meta-oniro-core/recipes-core/images/oniro-image-common.inc:22
#     " ${@bb.utils.contains('MACHINE_FEATURES', 'optee', 'optee-client', '', d)} "
# pre-expansion value:
#   "${CORE_IMAGE_BASE_INSTALL}sudo         packagegroup-oniro-core             packagegroup-net-essentials             packagegroup-ble-essentials             sysota          rauc-hawkbit-updater            kernel-image             ${@bb.utils.contains('MACHINE_FEATURES', 'optee', 'optee-client', '', d)} "
IMAGE_INSTALL="    packagegroup-core-boot     packagegroup-base-extended              sudo          packagegroup-oniro-core             packagegroup-net-essentials             packagegroup-ble-essentials             sysota          rauc-hawkbit-updater            kernel-image              "
#

Yocto project reference manual doesn't recommend usage of "+=" syntax for IMAGE_INSTALL because of ordering issues. That's the issue we have here:

1. IMAGE_INSTALL += "sudo" is expanded immediately and IMAGE_INSTALL is set to "sudo" at this point
2. at core-image.bbclass IMAGE_INSTALL ?= "${CORE_IMAGE_BASE_INSTALL}" doesn't have any effect because IMAGE_INSTALL is set already so packagegroup-core-boot is not appended and system is failed to boot as the result.

with overriding style syntax (:append) this is not happening because its effect is applied at variable expansion time rather than being immediately applied.

The only workaround to make "IMAGE_INSTALL+=" working I can imagine is to append ${CORE_IMAGE_BASE_INSTALL} in oniro-image-common.inc which will cause duplicating of packagegroup-core-boot and packagegroup-base-extended in the IMAGE_INSTALL list if "IMAGE_INSTALL+=" is not used in local.conf or shell env. variable which looks a bit ugly so please use :append instead in the local.conf

closed

marked this issue as related to #632 (closed)

removed needs-investigation label

removed IssueBug label

changed iteration to Oniro Core Iterations Jun 1, 2022 - Jun 30, 2022