Skip to content
Snippets Groups Projects
Commit 1fdec59b authored by Andi-Bogdan Postelnicu's avatar Andi-Bogdan Postelnicu Committed by Tom Stellard
Browse files

[lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Fix fallout caused by D89156 on 11.0.1 for MacOS

Differential Revision: https://reviews.llvm.org/D95683
parent 85fcd465
No related merge requests found
...@@ -282,7 +282,7 @@ Status PlatformAppleTVSimulator::GetSymbolFile(const FileSpec &platform_file, ...@@ -282,7 +282,7 @@ Status PlatformAppleTVSimulator::GetSymbolFile(const FileSpec &platform_file,
Status PlatformAppleTVSimulator::GetSharedModule( Status PlatformAppleTVSimulator::GetSharedModule(
const ModuleSpec &module_spec, lldb_private::Process *process, const ModuleSpec &module_spec, lldb_private::Process *process,
ModuleSP &module_sp, const FileSpecList *module_search_paths_ptr, ModuleSP &module_sp, const FileSpecList *module_search_paths_ptr,
ModuleSP *old_module_sp_ptr, bool *did_create_ptr) { llvm::SmallVectorImpl<lldb::ModuleSP> *old_modules, bool *did_create_ptr) {
// For AppleTV, the SDK files are all cached locally on the host system. So // For AppleTV, the SDK files are all cached locally on the host system. So
// first we ask for the file in the cached SDK, then we attempt to get a // first we ask for the file in the cached SDK, then we attempt to get a
// shared module for the right architecture with the right UUID. // shared module for the right architecture with the right UUID.
...@@ -296,9 +296,9 @@ Status PlatformAppleTVSimulator::GetSharedModule( ...@@ -296,9 +296,9 @@ Status PlatformAppleTVSimulator::GetSharedModule(
module_search_paths_ptr); module_search_paths_ptr);
} else { } else {
const bool always_create = false; const bool always_create = false;
error = ModuleList::GetSharedModule( error = ModuleList::GetSharedModule(module_spec, module_sp,
module_spec, module_sp, module_search_paths_ptr, old_module_sp_ptr, module_search_paths_ptr, old_modules,
did_create_ptr, always_create); did_create_ptr, always_create);
} }
if (module_sp) if (module_sp)
module_sp->SetPlatformFileSpec(platform_file); module_sp->SetPlatformFileSpec(platform_file);
......
...@@ -55,7 +55,7 @@ public: ...@@ -55,7 +55,7 @@ public:
GetSharedModule(const lldb_private::ModuleSpec &module_spec, GetSharedModule(const lldb_private::ModuleSpec &module_spec,
lldb_private::Process *process, lldb::ModuleSP &module_sp, lldb_private::Process *process, lldb::ModuleSP &module_sp,
const lldb_private::FileSpecList *module_search_paths_ptr, const lldb_private::FileSpecList *module_search_paths_ptr,
lldb::ModuleSP *old_module_sp_ptr, llvm::SmallVectorImpl<lldb::ModuleSP> *old_modules,
bool *did_create_ptr) override; bool *did_create_ptr) override;
uint32_t uint32_t
......
...@@ -283,7 +283,7 @@ Status PlatformAppleWatchSimulator::GetSymbolFile(const FileSpec &platform_file, ...@@ -283,7 +283,7 @@ Status PlatformAppleWatchSimulator::GetSymbolFile(const FileSpec &platform_file,
Status PlatformAppleWatchSimulator::GetSharedModule( Status PlatformAppleWatchSimulator::GetSharedModule(
const ModuleSpec &module_spec, lldb_private::Process *process, const ModuleSpec &module_spec, lldb_private::Process *process,
ModuleSP &module_sp, const FileSpecList *module_search_paths_ptr, ModuleSP &module_sp, const FileSpecList *module_search_paths_ptr,
ModuleSP *old_module_sp_ptr, bool *did_create_ptr) { llvm::SmallVectorImpl<lldb::ModuleSP> *old_modules, bool *did_create_ptr) {
// For AppleWatch, the SDK files are all cached locally on the host system. // For AppleWatch, the SDK files are all cached locally on the host system.
// So first we ask for the file in the cached SDK, then we attempt to get a // So first we ask for the file in the cached SDK, then we attempt to get a
// shared module for the right architecture with the right UUID. // shared module for the right architecture with the right UUID.
...@@ -297,9 +297,9 @@ Status PlatformAppleWatchSimulator::GetSharedModule( ...@@ -297,9 +297,9 @@ Status PlatformAppleWatchSimulator::GetSharedModule(
module_search_paths_ptr); module_search_paths_ptr);
} else { } else {
const bool always_create = false; const bool always_create = false;
error = ModuleList::GetSharedModule( error = ModuleList::GetSharedModule(module_spec, module_sp,
module_spec, module_sp, module_search_paths_ptr, old_module_sp_ptr, module_search_paths_ptr, old_modules,
did_create_ptr, always_create); did_create_ptr, always_create);
} }
if (module_sp) if (module_sp)
module_sp->SetPlatformFileSpec(platform_file); module_sp->SetPlatformFileSpec(platform_file);
......
...@@ -55,7 +55,7 @@ public: ...@@ -55,7 +55,7 @@ public:
GetSharedModule(const lldb_private::ModuleSpec &module_spec, GetSharedModule(const lldb_private::ModuleSpec &module_spec,
lldb_private::Process *process, lldb::ModuleSP &module_sp, lldb_private::Process *process, lldb::ModuleSP &module_sp,
const lldb_private::FileSpecList *module_search_paths_ptr, const lldb_private::FileSpecList *module_search_paths_ptr,
lldb::ModuleSP *old_module_sp_ptr, llvm::SmallVectorImpl<lldb::ModuleSP> *old_modules,
bool *did_create_ptr) override; bool *did_create_ptr) override;
uint32_t uint32_t
......
...@@ -730,7 +730,7 @@ Status PlatformDarwinKernel::GetSharedModule( ...@@ -730,7 +730,7 @@ Status PlatformDarwinKernel::GetSharedModule(
// framework on macOS systems, a chance. // framework on macOS systems, a chance.
error = PlatformDarwin::GetSharedModule(module_spec, process, module_sp, error = PlatformDarwin::GetSharedModule(module_spec, process, module_sp,
module_search_paths_ptr, module_search_paths_ptr,
old_module_sp_ptr, did_create_ptr); old_modules, did_create_ptr);
if (error.Success() && module_sp.get()) { if (error.Success() && module_sp.get()) {
return error; return error;
} }
......
...@@ -286,8 +286,8 @@ Status PlatformiOSSimulator::GetSymbolFile(const FileSpec &platform_file, ...@@ -286,8 +286,8 @@ Status PlatformiOSSimulator::GetSymbolFile(const FileSpec &platform_file,
Status PlatformiOSSimulator::GetSharedModule( Status PlatformiOSSimulator::GetSharedModule(
const ModuleSpec &module_spec, Process *process, ModuleSP &module_sp, const ModuleSpec &module_spec, Process *process, ModuleSP &module_sp,
const FileSpecList *module_search_paths_ptr, ModuleSP *old_module_sp_ptr, const FileSpecList *module_search_paths_ptr,
bool *did_create_ptr) { llvm::SmallVectorImpl<lldb::ModuleSP> *old_modules, bool *did_create_ptr) {
// For iOS, the SDK files are all cached locally on the host system. So first // For iOS, the SDK files are all cached locally on the host system. So first
// we ask for the file in the cached SDK, then we attempt to get a shared // we ask for the file in the cached SDK, then we attempt to get a shared
// module for the right architecture with the right UUID. // module for the right architecture with the right UUID.
...@@ -301,9 +301,9 @@ Status PlatformiOSSimulator::GetSharedModule( ...@@ -301,9 +301,9 @@ Status PlatformiOSSimulator::GetSharedModule(
module_search_paths_ptr); module_search_paths_ptr);
} else { } else {
const bool always_create = false; const bool always_create = false;
error = ModuleList::GetSharedModule( error = ModuleList::GetSharedModule(module_spec, module_sp,
module_spec, module_sp, module_search_paths_ptr, old_module_sp_ptr, module_search_paths_ptr, old_modules,
did_create_ptr, always_create); did_create_ptr, always_create);
} }
if (module_sp) if (module_sp)
module_sp->SetPlatformFileSpec(platform_file); module_sp->SetPlatformFileSpec(platform_file);
......
...@@ -57,7 +57,7 @@ public: ...@@ -57,7 +57,7 @@ public:
GetSharedModule(const lldb_private::ModuleSpec &module_spec, GetSharedModule(const lldb_private::ModuleSpec &module_spec,
lldb_private::Process *process, lldb::ModuleSP &module_sp, lldb_private::Process *process, lldb::ModuleSP &module_sp,
const lldb_private::FileSpecList *module_search_paths_ptr, const lldb_private::FileSpecList *module_search_paths_ptr,
lldb::ModuleSP *old_module_sp_ptr, llvm::SmallVectorImpl<lldb::ModuleSP> *old_modules,
bool *did_create_ptr) override; bool *did_create_ptr) override;
uint32_t uint32_t
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment