Skip to content
  • Tim Northover's avatar
    420a2168
    IR: add "cmpxchg weak" variant to support permitted failure. · 420a2168
    Tim Northover authored
    This commit adds a weak variant of the cmpxchg operation, as described
    in C++11. A cmpxchg instruction with this modifier is permitted to
    fail to store, even if the comparison indicated it should.
    
    As a result, cmpxchg instructions must return a flag indicating
    success in addition to their original iN value loaded. Thus, for
    uniformity *all* cmpxchg instructions now return "{ iN, i1 }". The
    second flag is 1 when the store succeeded.
    
    At the DAG level, a new ATOMIC_CMP_SWAP_WITH_SUCCESS node has been
    added as the natural representation for the new cmpxchg instructions.
    It is a strong cmpxchg.
    
    By default this gets Expanded to the existing ATOMIC_CMP_SWAP during
    Legalization, so existing backends should see no change in behaviour.
    If they wish to deal with the enhanced node instead, they can call
    setOperationAction on it. Beware: as a node with 2 results, it cannot
    be selected from TableGen.
    
    Currently, no use is made of the extra information provided in this
    patch. Test updates are almost entirely adapting the input IR to the
    new scheme.
    
    Summary for out of tree users:
    ------------------------------
    
    + Legacy Bitcode files are upgraded during read.
    + Legacy assembly IR files will be invalid.
    + Front-ends must adapt to different type for "cmpxchg".
    + Backends should be unaffected by default.
    
    llvm-svn: 210903
    420a2168
    IR: add "cmpxchg weak" variant to support permitted failure.
    Tim Northover authored
    This commit adds a weak variant of the cmpxchg operation, as described
    in C++11. A cmpxchg instruction with this modifier is permitted to
    fail to store, even if the comparison indicated it should.
    
    As a result, cmpxchg instructions must return a flag indicating
    success in addition to their original iN value loaded. Thus, for
    uniformity *all* cmpxchg instructions now return "{ iN, i1 }". The
    second flag is 1 when the store succeeded.
    
    At the DAG level, a new ATOMIC_CMP_SWAP_WITH_SUCCESS node has been
    added as the natural representation for the new cmpxchg instructions.
    It is a strong cmpxchg.
    
    By default this gets Expanded to the existing ATOMIC_CMP_SWAP during
    Legalization, so existing backends should see no change in behaviour.
    If they wish to deal with the enhanced node instead, they can call
    setOperationAction on it. Beware: as a node with 2 results, it cannot
    be selected from TableGen.
    
    Currently, no use is made of the extra information provided in this
    patch. Test updates are almost entirely adapting the input IR to the
    new scheme.
    
    Summary for out of tree users:
    ------------------------------
    
    + Legacy Bitcode files are upgraded during read.
    + Legacy assembly IR files will be invalid.
    + Front-ends must adapt to different type for "cmpxchg".
    + Backends should be unaffected by default.
    
    llvm-svn: 210903
Loading