Skip to content
  • Reid Kleckner's avatar
    60381791
    Rename llvm.frameescape and llvm.framerecover to localescape and localrecover · 60381791
    Reid Kleckner authored
    Summary:
    Initially, these intrinsics seemed like part of a family of "frame"
    related intrinsics, but now I think that's more confusing than helpful.
    Initially, the LangRef specified that this would create a new kind of
    allocation that would be allocated at a fixed offset from the frame
    pointer (EBP/RBP). We ended up dropping that design, and leaving the
    stack frame layout alone.
    
    These intrinsics are really about sharing local stack allocations, not
    frame pointers. I intend to go further and add an `llvm.localaddress()`
    intrinsic that returns whatever register (EBP, ESI, ESP, RBX) is being
    used to address locals, which should not be confused with the frame
    pointer.
    
    Naming suggestions at this point are welcome, I'm happy to re-run sed.
    
    Reviewers: majnemer, nicholas
    
    Subscribers: llvm-commits
    
    Differential Revision: http://reviews.llvm.org/D11011
    
    llvm-svn: 241633
    60381791
    Rename llvm.frameescape and llvm.framerecover to localescape and localrecover
    Reid Kleckner authored
    Summary:
    Initially, these intrinsics seemed like part of a family of "frame"
    related intrinsics, but now I think that's more confusing than helpful.
    Initially, the LangRef specified that this would create a new kind of
    allocation that would be allocated at a fixed offset from the frame
    pointer (EBP/RBP). We ended up dropping that design, and leaving the
    stack frame layout alone.
    
    These intrinsics are really about sharing local stack allocations, not
    frame pointers. I intend to go further and add an `llvm.localaddress()`
    intrinsic that returns whatever register (EBP, ESI, ESP, RBX) is being
    used to address locals, which should not be confused with the frame
    pointer.
    
    Naming suggestions at this point are welcome, I'm happy to re-run sed.
    
    Reviewers: majnemer, nicholas
    
    Subscribers: llvm-commits
    
    Differential Revision: http://reviews.llvm.org/D11011
    
    llvm-svn: 241633
Loading