Skip to content
Snippets Groups Projects
  1. Apr 19, 2020
  2. Mar 08, 2020
  3. Feb 15, 2020
  4. Dec 01, 2019
  5. Jul 27, 2019
  6. Jun 19, 2019
  7. May 30, 2019
  8. May 21, 2019
  9. Apr 04, 2019
  10. Aug 19, 2018
  11. Jan 08, 2018
  12. Nov 02, 2017
    • Greg Kroah-Hartman's avatar
      License cleanup: add SPDX GPL-2.0 license identifier to files with no license · b2441318
      Greg Kroah-Hartman authored
      
      Many source files in the tree are missing licensing information, which
      makes it harder for compliance tools to determine the correct license.
      
      By default all files without license information are under the default
      license of the kernel, which is GPL version 2.
      
      Update the files which contain no license information with the 'GPL-2.0'
      SPDX license identifier.  The SPDX identifier is a legally binding
      shorthand, which can be used instead of the full boiler plate text.
      
      This patch is based on work done by Thomas Gleixner and Kate Stewart and
      Philippe Ombredanne.
      
      How this work was done:
      
      Patches were generated and checked against linux-4.14-rc6 for a subset of
      the use cases:
       - file had no licensing information it it.
       - file was a */uapi/* one with no licensing information in it,
       - file was a */uapi/* one with existing licensing information,
      
      Further patches will be generated in subsequent months to fix up cases
      where non-standard license headers were used, and references to license
      had to be inferred by heuristics based on keywords.
      
      The analysis to determine which SPDX License Identifier to be applied to
      a file was done in a spreadsheet of side by side results from of the
      output of two independent scanners (ScanCode & Windriver) producing SPDX
      tag:value files created by Philippe Ombredanne.  Philippe prepared the
      base worksheet, and did an initial spot review of a few 1000 files.
      
      The 4.13 kernel was the starting point of the analysis with 60,537 files
      assessed.  Kate Stewart did a file by file comparison of the scanner
      results in the spreadsheet to determine which SPDX license identifier(s)
      to be applied to the file. She confirmed any determination that was not
      immediately clear with lawyers working with the Linux Foundation.
      
      Criteria used to select files for SPDX license identifier tagging was:
       - Files considered eligible had to be source code files.
       - Make and config files were included as candidates if they contained >5
         lines of source
       - File already had some variant of a license header in it (even if <5
         lines).
      
      All documentation files were explicitly excluded.
      
      The following heuristics were used to determine which SPDX license
      identifiers to apply.
      
       - when both scanners couldn't find any license traces, file was
         considered to have no license information in it, and the top level
         COPYING file license applied.
      
         For non */uapi/* files that summary was:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|-------
         GPL-2.0                                              11139
      
         and resulted in the first patch in this series.
      
         If that file was a */uapi/* path one, it was "GPL-2.0 WITH
         Linux-syscall-note" otherwise it was "GPL-2.0".  Results of that was:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|-------
         GPL-2.0 WITH Linux-syscall-note                        930
      
         and resulted in the second patch in this series.
      
       - if a file had some form of licensing information in it, and was one
         of the */uapi/* ones, it was denoted with the Linux-syscall-note if
         any GPL family license was found in the file or had no licensing in
         it (per prior point).  Results summary:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|------
         GPL-2.0 WITH Linux-syscall-note                       270
         GPL-2.0+ WITH Linux-syscall-note                      169
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause)    21
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)    17
         LGPL-2.1+ WITH Linux-syscall-note                      15
         GPL-1.0+ WITH Linux-syscall-note                       14
         ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause)    5
         LGPL-2.0+ WITH Linux-syscall-note                       4
         LGPL-2.1 WITH Linux-syscall-note                        3
         ((GPL-2.0 WITH Linux-syscall-note) OR MIT)              3
         ((GPL-2.0 WITH Linux-syscall-note) AND MIT)             1
      
         and that resulted in the third patch in this series.
      
       - when the two scanners agreed on the detected license(s), that became
         the concluded license(s).
      
       - when there was disagreement between the two scanners (one detected a
         license but the other didn't, or they both detected different
         licenses) a manual inspection of the file occurred.
      
       - In most cases a manual inspection of the information in the file
         resulted in a clear resolution of the license that should apply (and
         which scanner probably needed to revisit its heuristics).
      
       - When it was not immediately clear, the license identifier was
         confirmed with lawyers working with the Linux Foundation.
      
       - If there was any question as to the appropriate license identifier,
         the file was flagged for further research and to be revisited later
         in time.
      
      In total, over 70 hours of logged manual review was done on the
      spreadsheet to determine the SPDX license identifiers to apply to the
      source files by Kate, Philippe, Thomas and, in some cases, confirmation
      by lawyers working with the Linux Foundation.
      
      Kate also obtained a third independent scan of the 4.13 code base from
      FOSSology, and compared selected files where the other two scanners
      disagreed against that SPDX file, to see if there was new insights.  The
      Windriver scanner is based on an older version of FOSSology in part, so
      they are related.
      
      Thomas did random spot checks in about 500 files from the spreadsheets
      for the uapi headers and agreed with SPDX license identifier in the
      files he inspected. For the non-uapi files Thomas did random spot checks
      in about 15000 files.
      
      In initial set of patches against 4.14-rc6, 3 files were found to have
      copy/paste license identifier errors, and have been fixed to reflect the
      correct identifier.
      
      Additionally Philippe spent 10 hours this week doing a detailed manual
      inspection and review of the 12,461 patched files from the initial patch
      version early this week with:
       - a full scancode scan run, collecting the matched texts, detected
         license ids and scores
       - reviewing anything where there was a license detected (about 500+
         files) to ensure that the applied SPDX license was correct
       - reviewing anything where there was no detection but the patch license
         was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
         SPDX license was correct
      
      This produced a worksheet with 20 files needing minor correction.  This
      worksheet was then exported into 3 different .csv files for the
      different types of files to be modified.
      
      These .csv files were then reviewed by Greg.  Thomas wrote a script to
      parse the csv files and add the proper SPDX tag to the file, in the
      format that the file expected.  This script was further refined by Greg
      based on the output to detect more types of files automatically and to
      distinguish between header and source .c files (which need different
      comment types.)  Finally Greg ran the script using the .csv files to
      generate the patches.
      
      Reviewed-by: default avatarKate Stewart <kstewart@linuxfoundation.org>
      Reviewed-by: default avatarPhilippe Ombredanne <pombredanne@nexb.com>
      Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b2441318
  13. Oct 19, 2017
  14. Sep 26, 2017
  15. Sep 24, 2017
  16. Sep 04, 2017
  17. Aug 22, 2017
  18. Aug 20, 2017
  19. Aug 12, 2017
  20. Jul 30, 2017
  21. Jun 11, 2017
  22. May 07, 2017
  23. Apr 14, 2017
  24. Apr 08, 2017
    • Fabrice Gasnier's avatar
      iio: stm32 trigger: fix sampling_frequency read · 77a9febf
      Fabrice Gasnier authored
      
      When prescaler (PSC) is 0, it means div factor is 1: counter clock
      frequency is equal to input clk / (PSC + 1).
      When reload value is 8 for example, counter counts 9 cycles, from 0 to 8.
      This is handled in frequency write routine, by writing respectively:
      - prescaler - 1 to PSC
      - reload value - 1 to ARR
      This fix does the opposite when reading the frequency from PSC and ARR:
      - prescaler is PSC + 1
      - reload value is ARR + 1
      
      Thus, PSC may be 0, depending on requested sampling frequency (div 1).
      In this case, reading freq wrongly reports 0, instead of computing and
      reporting correct value.
      Remove test on !psc and !arr.
      
      Small test on stm32f4 (example on tim1_trgo), before this fix:
      $ cd /sys/bus/iio/devices/triggerX
      $ echo 10000 > sampling_frequency
      $ cat sampling_frequency
      0
      
      After this fix:
      $ echo 10000 > sampling_frequency
      $ cat sampling_frequency
      10000
      
      Signed-off-by: default avatarFabrice Gasnier <fabrice.gasnier@st.com>
      Cc: <Stable@vger.kernel.org>
      Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
      77a9febf
  25. Jan 25, 2017
    • Benjamin Gaignard's avatar
      iio: Add STM32 timer trigger driver · 93fbe91b
      Benjamin Gaignard authored
      
      Timers IPs can be used to generate triggers for other IPs like
      DAC or ADC.
      Each trigger may result of timer internals signals like counter enable,
      reset or edge, this configuration could be done through "master_mode"
      device attribute.
      
      Since triggers could be used by DAC or ADC their names are defined
      in include/ nux/iio/timer/stm32-timer-trigger.h and is_stm32_iio_timer_trigger
      function could be used to check if the trigger is valid or not.
      
      "trgo" trigger have a "sampling_frequency" attribute which allow to configure
      timer sampling frequency.
      
      version 8:
      - change kernel version from 4.10 to 4.11 in ABI documentation
      
      version 7:
      - remove all iio_device related code
      - move driver into trigger directory
      
      version 5:
      - simplify tables of triggers
      - only create an IIO device when needed
      
      version 4:
      - get triggers configuration from "reg" in DT
      - add tables of triggers
      - sampling frequency is enable/disable when writing in trigger
        sampling_frequency attribute
      - no more use of interruptions
      
      version 3:
      - change compatible to "st,stm32-timer-trigger"
      - fix attributes access right
      - use string instead of int for master_mode and slave_mode
      - document device attributes in sysfs-bus-iio-timer-stm32
      
      version 2:
      - keep only one compatible
      - use st,input-triggers-names and st,output-triggers-names
        to know which triggers are accepted and/or create by the device
      
      Signed-off-by: default avatarBenjamin Gaignard <benjamin.gaignard@st.com>
      Acked-by: default avatarJonathan Cameron <jic23@kernel.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      93fbe91b
  26. Jan 22, 2017
    • Alison Schofield's avatar
      iio: trigger: free trigger resource correctly · 10e840df
      Alison Schofield authored
      
      These stand-alone trigger drivers were using iio_trigger_put()
      where they should have been using iio_trigger_free().  The
      iio_trigger_put() adds a module_put which is bad since they
      never did a module_get.
      
      In the sysfs driver, module_get/put's are used as triggers are
      added & removed. This extra module_put() occurs on an error path
      in the probe routine (probably rare).
      
      In the bfin-timer & interrupt trigger drivers, the module resources
      are not explicitly managed, so it's doing a put on something that
      was never get'd.  It occurs on the probe error path and on the
      remove path (not so rare).
      
      Tested with the sysfs trigger driver.
      The bfin & interrupt drivers were build tested & inspected only.
      
      Signed-off-by: default avatarAlison Schofield <amsfield22@gmail.com>
      Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
      10e840df
  27. Dec 25, 2016
    • Thomas Gleixner's avatar
      ktime: Cleanup ktime_set() usage · 8b0e1953
      Thomas Gleixner authored
      
      ktime_set(S,N) was required for the timespec storage type and is still
      useful for situations where a Seconds and Nanoseconds part of a time value
      needs to be converted. For anything where the Seconds argument is 0, this
      is pointless and can be replaced with a simple assignment.
      
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Cc: Peter Zijlstra <peterz@infradead.org>
      8b0e1953
  28. Jun 03, 2016
    • Jonathan Cameron's avatar
      iio:trigger: Experimental kthread tight loop trigger (thread only) · bc2e1126
      Jonathan Cameron authored
      
      This patch is in response to that of
      Gregor Boirie <gregor.boirie@parrot.com>
      who proposed using a tight kthread within a device driver (be it with the
      support factored out into a helper library) in order to basically spin as
      fast as possible.
      
      It is meant as a talking point rather than a formal proposal of the code
      (though we are heading towards that I think).
      Also gives people some working code to mess around with.
      
      I proposed that this could be done with a trigger with a few constraints
      and this is the proof (be it ugly) of that.
      
      There are some constraints though, some of which we would want to relax
      if this were to move forward.
      
      * Will only run the thread part of the registered pollfunc.  This is to
        avoid the overhead of jumping in and out of interrupt context.  Is the
        overhead significant?  Not certain but feels like it should be!
      
      * This limitation precludes any device that 'must' do some work in
        interrupt context.  However, that is true of few if any drivers and
        I suspect that any that do will be restricted to using triggers they
        provide themselves.  Usually we have a top half mainly to grab a
        timestamp as soon after the dataready type signal as possible.
      
      Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
      Acked-by: default avatarDaniel Baluta <daniel.baluta@intel.com>
      bc2e1126
  29. Dec 03, 2015
  30. Dec 26, 2014
  31. Aug 26, 2014
  32. Jun 14, 2014
Loading