Skip to content
Snippets Groups Projects
Commit fd87f837 authored by Yu Kuai's avatar Yu Kuai Committed by Greg Kroah-Hartman
Browse files

iommu/exynos: add missing put_device() call in exynos_iommu_of_xlate()


[ Upstream commit 1a260449 ]

if of_find_device_by_node() succeed, exynos_iommu_of_xlate() doesn't have
a corresponding put_device(). Thus add put_device() to fix the exception
handling for this function implementation.

Fixes: aa759fd3 ("iommu/exynos: Add callback for initializing devices from device tree")
Signed-off-by: default avatarYu Kuai <yukuai3@huawei.com>
Acked-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Link: https://lore.kernel.org/r/20200918011335.909141-1-yukuai3@huawei.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent eb8eda5b
No related branches found
No related tags found
No related merge requests found
...@@ -1265,13 +1265,17 @@ static int exynos_iommu_of_xlate(struct device *dev, ...@@ -1265,13 +1265,17 @@ static int exynos_iommu_of_xlate(struct device *dev,
return -ENODEV; return -ENODEV;
data = platform_get_drvdata(sysmmu); data = platform_get_drvdata(sysmmu);
if (!data) if (!data) {
put_device(&sysmmu->dev);
return -ENODEV; return -ENODEV;
}
if (!owner) { if (!owner) {
owner = kzalloc(sizeof(*owner), GFP_KERNEL); owner = kzalloc(sizeof(*owner), GFP_KERNEL);
if (!owner) if (!owner) {
put_device(&sysmmu->dev);
return -ENOMEM; return -ENOMEM;
}
INIT_LIST_HEAD(&owner->controllers); INIT_LIST_HEAD(&owner->controllers);
dev->archdata.iommu = owner; dev->archdata.iommu = owner;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment