Skip to content
Snippets Groups Projects
Commit e9a902f8 authored by Zhen Lei's avatar Zhen Lei Committed by Greg Kroah-Hartman
Browse files

genirq/timings: Fix error return code in irq_timings_test_irqs()


[ Upstream commit 290fdc4b ]

Return a negative error code from the error handling case instead of 0, as
done elsewhere in this function.

Fixes: f52da98d ("genirq/timings: Add selftest for irqs circular buffer")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20210811093333.2376-1-thunder.leizhen@huawei.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 10d3bdd2
No related branches found
No related tags found
1 merge request!15.10.61 -> 5.10.152 upgrade
...@@ -799,12 +799,14 @@ static int __init irq_timings_test_irqs(struct timings_intervals *ti) ...@@ -799,12 +799,14 @@ static int __init irq_timings_test_irqs(struct timings_intervals *ti)
__irq_timings_store(irq, irqs, ti->intervals[i]); __irq_timings_store(irq, irqs, ti->intervals[i]);
if (irqs->circ_timings[i & IRQ_TIMINGS_MASK] != index) { if (irqs->circ_timings[i & IRQ_TIMINGS_MASK] != index) {
ret = -EBADSLT;
pr_err("Failed to store in the circular buffer\n"); pr_err("Failed to store in the circular buffer\n");
goto out; goto out;
} }
} }
if (irqs->count != ti->count) { if (irqs->count != ti->count) {
ret = -ERANGE;
pr_err("Count differs\n"); pr_err("Count differs\n");
goto out; goto out;
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment