Skip to content
Snippets Groups Projects
Commit e8dfc446 authored by Masami Hiramatsu's avatar Masami Hiramatsu Committed by Greg Kroah-Hartman
Browse files

tracing/boot: Fix a hist trigger dependency for boot time tracing

[ Upstream commit 6fe7c745 ]

Fixes a build error when CONFIG_HIST_TRIGGERS=n with boot-time
tracing. Since the trigger_process_regex() is defined only
when CONFIG_HIST_TRIGGERS=y, if it is disabled, the 'actions'
event option also must be disabled.

Link: https://lkml.kernel.org/r/162856123376.203126.582144262622247352.stgit@devnote2



Fixes: 81a59555 ("tracing/boot: Add per-event settings")
Signed-off-by: default avatarMasami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 87479b10
No related branches found
No related tags found
1 merge request!15.10.61 -> 5.10.152 upgrade
...@@ -205,12 +205,15 @@ trace_boot_init_one_event(struct trace_array *tr, struct xbc_node *gnode, ...@@ -205,12 +205,15 @@ trace_boot_init_one_event(struct trace_array *tr, struct xbc_node *gnode,
pr_err("Failed to apply filter: %s\n", buf); pr_err("Failed to apply filter: %s\n", buf);
} }
xbc_node_for_each_array_value(enode, "actions", anode, p) { if (IS_ENABLED(CONFIG_HIST_TRIGGERS)) {
if (strlcpy(buf, p, ARRAY_SIZE(buf)) >= ARRAY_SIZE(buf)) xbc_node_for_each_array_value(enode, "actions", anode, p) {
pr_err("action string is too long: %s\n", p); if (strlcpy(buf, p, ARRAY_SIZE(buf)) >= ARRAY_SIZE(buf))
else if (trigger_process_regex(file, buf) < 0) pr_err("action string is too long: %s\n", p);
pr_err("Failed to apply an action: %s\n", buf); else if (trigger_process_regex(file, buf) < 0)
} pr_err("Failed to apply an action: %s\n", buf);
}
} else if (xbc_node_find_value(enode, "actions", NULL))
pr_err("Failed to apply event actions because CONFIG_HIST_TRIGGERS is not set.\n");
if (xbc_node_find_value(enode, "enable", NULL)) { if (xbc_node_find_value(enode, "enable", NULL)) {
if (trace_event_enable_disable(file, 1, 0) < 0) if (trace_event_enable_disable(file, 1, 0) < 0)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment