Skip to content
Snippets Groups Projects
Commit aaeeb3e6 authored by Peter Zijlstra's avatar Peter Zijlstra Committed by Ben Hutchings
Browse files

perf/core: Fix perf_sample_regs_user() mm check


commit 085ebfe9 upstream.

perf_sample_regs_user() uses 'current->mm' to test for the presence of
userspace, but this is insufficient, consider use_mm().

A better test is: '!(current->flags & PF_KTHREAD)', exec() clears
PF_KTHREAD after it sets the new ->mm but before it drops to userspace
for the first time.

Possibly obsoletes: bf05fc25 ("powerpc/perf: Fix oops when kthread execs user process")

Reported-by: default avatarRavi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Reported-by: default avatarYoung Xiao <92siuyang@gmail.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: default avatarWill Deacon <will.deacon@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 4018994f ("perf: Add ability to attach user level registers dump to sample")
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent 1bad37d8
No related branches found
No related tags found
No related merge requests found
...@@ -4581,7 +4581,7 @@ static void perf_sample_regs_user(struct perf_regs_user *regs_user, ...@@ -4581,7 +4581,7 @@ static void perf_sample_regs_user(struct perf_regs_user *regs_user,
struct pt_regs *regs) struct pt_regs *regs)
{ {
if (!user_mode(regs)) { if (!user_mode(regs)) {
if (current->mm) if (!(current->flags & PF_KTHREAD))
regs = task_pt_regs(current); regs = task_pt_regs(current);
else else
regs = NULL; regs = NULL;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment