Skip to content
Snippets Groups Projects
Commit 0e5dbea8 authored by Yangtao Li's avatar Yangtao Li Committed by Greg Kroah-Hartman
Browse files

clk: socfpga: fix refcount leak


[ Upstream commit 7f9705be ]

The of_find_compatible_node() returns a node pointer with refcount
incremented, but there is the lack of use of the of_node_put() when
done. Add the missing of_node_put() to release the refcount.

Signed-off-by: default avatarYangtao Li <tiny.windzz@gmail.com>
Fixes: 5343325f ("clk: socfpga: add a clock driver for the Arria 10 platform")
Fixes: a30d27ed ("clk: socfpga: fix clock driver for 3.15")
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 6c3e2bc4
No related merge requests found
...@@ -95,6 +95,7 @@ static struct clk * __init __socfpga_pll_init(struct device_node *node, ...@@ -95,6 +95,7 @@ static struct clk * __init __socfpga_pll_init(struct device_node *node,
clkmgr_np = of_find_compatible_node(NULL, NULL, "altr,clk-mgr"); clkmgr_np = of_find_compatible_node(NULL, NULL, "altr,clk-mgr");
clk_mgr_a10_base_addr = of_iomap(clkmgr_np, 0); clk_mgr_a10_base_addr = of_iomap(clkmgr_np, 0);
of_node_put(clkmgr_np);
BUG_ON(!clk_mgr_a10_base_addr); BUG_ON(!clk_mgr_a10_base_addr);
pll_clk->hw.reg = clk_mgr_a10_base_addr + reg; pll_clk->hw.reg = clk_mgr_a10_base_addr + reg;
......
...@@ -100,6 +100,7 @@ static __init struct clk *__socfpga_pll_init(struct device_node *node, ...@@ -100,6 +100,7 @@ static __init struct clk *__socfpga_pll_init(struct device_node *node,
clkmgr_np = of_find_compatible_node(NULL, NULL, "altr,clk-mgr"); clkmgr_np = of_find_compatible_node(NULL, NULL, "altr,clk-mgr");
clk_mgr_base_addr = of_iomap(clkmgr_np, 0); clk_mgr_base_addr = of_iomap(clkmgr_np, 0);
of_node_put(clkmgr_np);
BUG_ON(!clk_mgr_base_addr); BUG_ON(!clk_mgr_base_addr);
pll_clk->hw.reg = clk_mgr_base_addr + reg; pll_clk->hw.reg = clk_mgr_base_addr + reg;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment