Skip to content
  • Bjorn Helgaas's avatar
    6d3a1741
    PCI: Support PCIe Capability Slot registers only for ports with slots · 6d3a1741
    Bjorn Helgaas authored
    
    
    Previously we allowed callers to access Slot Capabilities, Status, and
    Control for Root Ports even if the Root Port did not implement a slot.
    This seems dubious because the spec only requires these registers if a
    slot is implemented.
    
    It's true that even Root Ports without slots must have *space* for these
    slot registers, because the Root Capabilities, Status, and Control
    registers are after the slot registers in the capability.  However,
    for a v1 PCIe Capability, the *semantics* of the slot registers are
    undefined unless a slot is implemented.
    
    Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
    Reviewed-By: default avatarJiang Liu <jiang.liu@huawei.com>
    6d3a1741
    PCI: Support PCIe Capability Slot registers only for ports with slots
    Bjorn Helgaas authored
    
    
    Previously we allowed callers to access Slot Capabilities, Status, and
    Control for Root Ports even if the Root Port did not implement a slot.
    This seems dubious because the spec only requires these registers if a
    slot is implemented.
    
    It's true that even Root Ports without slots must have *space* for these
    slot registers, because the Root Capabilities, Status, and Control
    registers are after the slot registers in the capability.  However,
    for a v1 PCIe Capability, the *semantics* of the slot registers are
    undefined unless a slot is implemented.
    
    Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
    Reviewed-By: default avatarJiang Liu <jiang.liu@huawei.com>
Loading