Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E eddie
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 12
    • Issues 12
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Eclipse ProjectsEclipse Projects
  • Oniro Core
  • eddie
  • Merge requests
  • !34

general restructuring, reimplement CoapNode into EddieEndpoint, extract resource directory code, fixes and improvements

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Francesco Pham requested to merge mrfrank/eddie:restructuring into main Aug 01, 2022
  • Overview 1
  • Commits 17
  • Pipelines 5
  • Changes 29

This large MR is a general restructuring of the code, but does not add any new feature. These changes, other than improving the code, also allows to share some code with the zephyr implementation.

  • Remove CoapNode and reimplement it into EddieEndpoint sharing the same header file used in zephyr
  • Refactor CoapServer.cpp extracting the resource directory code into its own class: improves readability of CoapServer.cpp file and also allows to run the resource directory as a standalone process.
  • replace printf and coap_log with LOG_ERR, LOG_INFO, LOG_DBG: this allows to set wanted log verbosity, or in the future log to a different location instead of stdout
  • fix segmentation fault problem
  • move send_message and receive_message methods into CoapClient
  • adapt virtualization to use EddieEndpoint instead of CoapNode

for more details see the git history

Signed-off-by: Francesco Pham francesco.pham@huawei.com

Edited Aug 01, 2022 by Francesco Pham
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: restructuring

Copyright © Eclipse Foundation, Inc. All Rights Reserved.     Privacy Policy | Terms of Use | Copyright Agent