Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • I ice
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 14
    • Issues 14
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Eclipse ProjectsEclipse Projects
  • The Eclipse Integrated Computational Environment
  • ice
  • Merge requests
  • !455

Fix VelocityProperties and Annotation Processor Logging

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Eclipse Webmaster requested to merge github/fork/dbluhm/hotfix-20200806 into next Aug 06, 2020
  • Overview 1
  • Commits 3
  • Changes 6

Created by: dbluhm

This PR fixes two issues:

  • VelocityProperties was set to load from a file when it should have been loading from a resource
  • Annotation processor logging the way I set it up would conflict with any logger implementations put on dependent projects. I reverted the main DataElementProcessor to extend the usual AbstractProcessor and wrote a quick wrapper around it for use in testing that adds in the logging functionality. With that in place, the annotation-processor-logging library is a test only dependency, solving our logger conflict problems.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/dbluhm/hotfix-20200806

Copyright © Eclipse Foundation, Inc. All Rights Reserved.     Privacy Policy | Terms of Use | Copyright Agent