Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E Eclipse eTrice
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 58
    • Issues 58
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 8
    • Merge requests 8
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Eclipse ProjectsEclipse Projects
  • Eclipse eTrice™
  • Eclipse eTrice
  • Merge requests
  • !15

[core.room] fix binding validation to check inherited external end ports

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Eyrak Paen-Rochlitz requested to merge 46-invalid-connection-inherited-structure-diagram into master May 23, 2022
  • Overview 2
  • Commits 1
  • Changes 3

Issue 46 is partly an awkward interaction between the diagram editor behavior and the core room xtext services. The diagram editor uses the xtext validator directly on combinations of EObjects that would normally not be possible in an xtext document (due to scope provider constraints). This means that the validator has to account for cases that are outside the possible xtext scope.

Not sure if this should be refactored in some way, or if it's worth it?

Commit message: Validation for connection of external end ports now also accounts for inherited ports. Note that due to current scope provider behavior, it is not actually possible in the textual editor to encounter this case. HOWEVER, it does become an issue in the diagram editor, because it currently uses ValidationUtil on arbitrary ports in the diagram without consulting the scope.

Issue #46 (closed)

Closes #46 (closed)

Edited May 23, 2022 by Eyrak Paen-Rochlitz
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 46-invalid-connection-inherited-structure-diagram

Copyright © Eclipse Foundation, Inc. All Rights Reserved.     Privacy Policy | Terms of Use | Copyright Agent