Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E escet
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare revisions
    • Locked files
  • Issues 93
    • Issues 93
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Eclipse ProjectsEclipse Projects
  • Eclipse ESCET (Supervisory Control Engineering Toolkit)
  • escet
  • Merge requests
  • !550

#563 Improve CIF data-synthesis main fixed point loop sections

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Dennis Hendriks requested to merge 563-improve-cif-data-synthesis-main-fixed-point-loop-comments into develop Apr 02, 2023
  • Overview 4
  • Commits 5
  • Pipelines 2
  • Changes 1
  • Changes: clearer comments to indicate which section belongs to which operation.
  • Dedicated 'end of fixed point loop' detections for 2nd and 3rd operations. No more split or shared functionality.
  • All changes of this branch are backward compatible. None of these changes change synthesis behavior (hence to test output has changed either). Only the code is changed to make it easier to follow.
  • I made separate commits to reduce the Git diff per commit as much as possible. The one where indentation is changed looks complicated, but only two code blocks changed indentation.
  • I know a lot else can be improved in the data-based synthesis tool, but the only goal here is to make the sections dedicated per operation, and to then make it clear to which operation each section belongs.

Closes #563 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 563-improve-cif-data-synthesis-main-fixed-point-loop-comments

Copyright © Eclipse Foundation, Inc. All Rights Reserved.     Privacy Policy | Terms of Use | Copyright Agent