Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E escet
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
    • Locked Files
  • Issues 92
    • Issues 92
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Eclipse ProjectsEclipse Projects
  • Eclipse ESCET (Supervisory Control Engineering Toolkit)
  • escet
  • Merge requests
  • !460

#426 Allow multiple occurrences of events in CIF data-based synthesis custom edge order

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dennis Hendriks requested to merge 426-cif-datasynth-edge-order-allow-duplicates into develop Dec 30, 2022
  • Overview 3
  • Commits 9
  • Pipelines 2
  • Changes 31

Notes:

  • This only allows multiple occurrences of the same event in the CIF data-based synthesis custom edge order. Adding automatic algorithms for doing so is out of scope for this issue and merge request.
  • The synthesis edges are used in various places during synthesis. I added a separate variable to store the ordered edges, with potential duplicates, for reachability computations. This means that determining output guards, edge debug output, etc, still operate on the edges without duplicates, to prevent duplicate work there. This does change the debug output, as they are now always the edges in model order.
  • By default, duplicates are disallowed. This ensures backward compatibility. It also allows to detect accidental duplicate inclusion of events in the order.
  • I used an enum-typed-option to allow configuring this rather than a boolean option. This allows adding additional 'automatic' variants later on, when we add automatic algorithms for heuristically computing edge orders.
  • I recommend reviewing per commit.

Closes #426 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 426-cif-datasynth-edge-order-allow-duplicates

Copyright © Eclipse Foundation, Inc. All Rights Reserved.     Privacy Policy | Terms of Use | Copyright Agent