Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E escet
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
    • Locked Files
  • Issues 92
    • Issues 92
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Eclipse ProjectsEclipse Projects
  • Eclipse ESCET (Supervisory Control Engineering Toolkit)
  • escet
  • Merge requests
  • !373

#416 Add tests for CIF common checks

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dennis Hendriks requested to merge 416-add-tests-for-cif-common-checks into develop Sep 25, 2022
  • Overview 11
  • Commits 13
  • Pipelines 2
  • Changes 92

Notes:

  • The CIF common checks are not application framework applications, but more like library functionality. I therefore added an application specifically for testing. Then I just used the integration test framework as usual.
  • I named the tests after the check class that they use, to allow the test application to be reused for all them.
  • The expression and type checks are parameterized. Hence, I created in the test plugin some derived classes. They essentially test per level (based on the number of '_' characters in the enum values). This allows testing for instance PLUS vs PLUS_INT vs PLUS_INT_RANGED. It doesn't test all 'logic paths', as PLUS_INT_RANGED and PLUS_INT_RANGELESS are still tested together. But we get quite some coverage this way.

I recommend reviewing the total changes, rather than the individual commits.

Closes #416 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 416-add-tests-for-cif-common-checks

Copyright © Eclipse Foundation, Inc. All Rights Reserved.     Privacy Policy | Terms of Use | Copyright Agent