Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E escet
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
    • Locked Files
  • Issues 90
    • Issues 90
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Eclipse ProjectsEclipse Projects
  • Eclipse ESCET (Supervisory Control Engineering Toolkit)
  • escet
  • Merge requests
  • !281

#330 #336 Use streaming for CifCollectUtils

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Albert Hofkamp requested to merge 330-stream-collecting into develop Mar 15, 2022
  • Overview 40
  • Commits 7
  • Pipelines 4
  • Changes 2

Looks pretty slick, one formatting problem though.

Formatter says (around line 57)

    public static void collectEvents(ComplexComponent comp, Collection<Event> events) {
        getComplexComponents(comp)
                .forEach(cc ->
                {  // <-- and checkStyle complains "Block start curly brace '{' should be on previous line."
                    cc.getDeclarations().stream().filter(decl -> decl instanceof Event)
                            .forEach(decl -> events.add((Event)decl));
                });
    }

Closes #330 (closed) #336 (closed)

Edited Mar 29, 2022 by Dennis Hendriks
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 330-stream-collecting

Copyright © Eclipse Foundation, Inc. All Rights Reserved.     Privacy Policy | Terms of Use | Copyright Agent