Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • E escet
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
    • Locked Files
  • Issues 92
    • Issues 92
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Eclipse ProjectsEclipse Projects
  • Eclipse ESCET (Supervisory Control Engineering Toolkit)
  • escet
  • Merge requests
  • !271

Draft: #316 Introduce small common position class in scanning and parsing

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Albert Hofkamp requested to merge 316-introduce-small-common-position into develop Feb 25, 2022
  • Overview 32
  • Commits 12
  • Pipelines 1
  • Changes 206

To avoid a forced connection between parsing a text file and having to import EMF, a very simple CommonPosition class is introduced without additional dependencies if so desired.

I have no errors, and I can build it locally. The number of files that it touches is somewhat insane, but changes are generally easy. A perhaps somewhat tricky part is whether I made the switch from CommonPosition to Position always at the right spot. At times I made life easy by adding an overload to a commonly called function, such as error reporting.

What may be incomplete are the manifest dependencies of some plugins, perhaps some position.metamodel bundle imports are no longer required.

Closes #316 (closed)

Edited Apr 04, 2022 by Albert Hofkamp
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 316-introduce-small-common-position

Copyright © Eclipse Foundation, Inc. All Rights Reserved.     Privacy Policy | Terms of Use | Copyright Agent