Change Gather and Slice's attributes into intputs
Context
For Gather
and Slice
Operator, we didn't keep the same standard as ONNX, some of the inputs were made attributes on Aidge. However these inputs might not be initializers on the ONNX model, so loading these attributes while importing the ONNX model is not possible. This is why this MR is intending to switch those attributes to inputs so we don't have to load them while creating the nodes.
For Gather operator:
- Indices
- GatheredShape
For Slice:
- Starts
- Ends
- Axes
Modified files
-
slice.py
-
gather.py
TODO
-
DONE : replace Slice attributes by inputs
-
DONE : replace Gather attributes by inputs
Merge request reports
Activity
requested review from @pineapple
requested review from @cmoineau
mentioned in issue aidge_core#118 (closed)
added 39 commits
-
bb26c7a0...6f081d7c - 37 commits from branch
eclipse/aidge:dev
- b96ede44 - switch gather attrs into input
- b60ba3da - switch slice attrs into inputs
-
bb26c7a0...6f081d7c - 37 commits from branch
assigned to @hrouis
added TopicOperator label
changed milestone to %aidge - May 2024
added Fix 🔥🔥 label
added 6 commits
-
b60ba3da...79123eb9 - 4 commits from branch
eclipse/aidge:dev
- 982823bf - switch gather attrs into input
- a47ed578 - switch slice attrs into inputs
-
b60ba3da...79123eb9 - 4 commits from branch
enabled an automatic merge when the pipeline for a47ed578 succeeds
mentioned in commit 6982a733