Skip to content

Fix naming issue (+ general improvements)

Cyril Moineau requested to merge Improvements into dev

Context

This MR brings some minor improvements to the module with no specific scope.

Minor:

  • dev: Refactoring of includes and typehint
  • feat: Producer node are now colored with a light blue color to differenciate them

Major:

  • fix: Fix the issue #1 (closed) by using an id unique by node instead of trying to rely on naming or rank. Allowing to have a unique id that is not lost after graph transformations!

Detailed modification

I wanted the id mechanism to be robust to graph transformation meaning that we could map nodes before and atfer transformations.

At first I used the pointer to the node object as a unique ID. I realized that function such as fuse_to_metaops clone nodes. Meaning the pointer are differents losing this mapping. That's why I created a dynamic attributes: model_explorer:id. This attribute is set to the pointer if it doesn't exist already. Meaning the a node will not lose it corresponding id after transformation.

Edited by Cyril Moineau

Merge request reports

Loading